Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From our discussions, this PR is intended to revamp the summary PDFs. Not all of the information will transfer to a new PDF, and some is moved to either a revamped
par_checkeror CI. This uses a spiritual successor toreport.py, but instead of logging information as it streams in, the report must be actively built.Included files:
markdownreport.py- includes theMarkdownSectionandMarkdownReportclasses. These act more generically and are used to store and generate the appropriate information.summarizer.py- include theSummarizerclass used to generate the report. These include timing-specific calls and glues everything together.To-dos:
pdf_writer()pdf_writer()