Skip to content

fix(typing): Narrow NativeSeries Protocol #2159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 7, 2025
Merged

fix(typing): Narrow NativeSeries Protocol #2159

merged 1 commit into from
Mar 7, 2025
+12 −6

Conversation

@dangotbanned
Copy link
Member

@dangotbanned dangotbanned commented Mar 6, 2025 •
edited
Loading

Closes #2111

What type of PR is this? (check all applicable)

  • 💾 Refactor
  • ✨ Feature
  • 🐛 Bug Fix
  • 🔧 Optimization
  • 📝 Documentation
  • ✅ Test
  • 🐳 Other

Related issues

Checklist

  • Code follows style guide (ruff)
  • Tests added
  • Documented the changes

If you have comments or can explain your changes, please do so below

Of the possible common methods, this avoids np.ndarray matching - as well as builtins.

Common methods

  • filter
  • unique
  • value_counts
  • equals
  • take (numpy)
  • to_numpy
  • __array__ (numpy)
  • __len__ (numpy)
  • __iter__ (numpy)

MarcoGorelli
MarcoGorelli approved these changes Mar 7, 2025
View reviewed changes
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @dangotbanned !

TIL that pandas.series has a filter method 😄

@MarcoGorelli MarcoGorelli merged commit de2e99c into main Mar 7, 2025
28 checks passed
@MarcoGorelli MarcoGorelli deleted the native-series-narrow branch March 7, 2025 15:14
@dangotbanned
Copy link
Member Author

thanks @dangotbanned !

TIL that pandas.series has a filter method 😄

68747470733a2f2f692e666c756666792e63632f7a566d673963736e337064467134533668514b484b7a64436c334237635276472e676966

Knowing pandas, it probably has no relation to what it does in polars or pyarrow - but it works for matching a protocol 😊

@dangotbanned dangotbanned mentioned this pull request Aug 5, 2025
Merged
10 tasks
@dangotbanned dangotbanned mentioned this pull request Aug 24, 2025
Merged
10 tasks
@dangotbanned dangotbanned mentioned this pull request Sep 15, 2025
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MarcoGorelli MarcoGorelli MarcoGorelli approved these changes

Assignees

No one assigned

Labels

fix typing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Tighten-up NativeSeries Protocol

3 participants

@dangotbanned @MarcoGorelli