feat: Binary dtype support
#2243
Conversation
FBruzzesi
left a comment
FBruzzesi
left a comment
There was a problem hiding this comment.
Thanks @marvinl803 🚀
I added a couple of commits to support spark-like as well and fix a typo in the docstrings.
I will wait for someone else to review this as I am a bit biased 😇
In the meanwhile, I opened a PR in py-shiny to add binary support there as well
|
@FBruzzesi feel free to ship! |
Thank you as well, @FBruzzesi I really appreciate it 🙌! |
| def test_cast_binary(request: pytest.FixtureRequest, constructor: Constructor) -> None: | ||
| if "pandas" in str(constructor) and PANDAS_VERSION < (2, 2): | ||
| request.applymarker(pytest.mark.xfail) | ||
|
|
||
| if any(backend in str(constructor) for backend in ("dask", "modin")): | ||
| request.applymarker(pytest.mark.xfail) |
There was a problem hiding this comment.
@marvinl803 could we also skip this test for cudf please?
There was a problem hiding this comment.
nevermind, just did it - thanks again for your pr!
There was a problem hiding this comment.
My bad, I just saw this. Absolutely no problem at all!
4 participants
What type of PR is this? (check all applicable)
Related issues
Binary&Timedatatype #1989Binary&Timedatatype #1989Checklist
If you have comments or can explain your changes, please do so below
This is a follow up to issue #1989 where it adds support to the Binary datatype. If there is any further changes needed, please let me know.