chore: Add support for Narwhals Binary dtype in serialize_dtype
#1928
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
|
Thank you! |
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for Narwhals' new Binary dtype by updating serialization logic.
- Added "binary" to the list of allowed dtypes in FrameDtypeSubset.
- Introduced a new conditional branch in serialize_dtype to convert nw.Binary to "binary".
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| shiny/render/_data_frame_utils/_types.py | Added "binary" to the FrameDtypeSubset list. |
| shiny/render/_data_frame_utils/_tbl_data.py | Added conditional branch to serialize nw.Binary as "binary". |
Comments suppressed due to low confidence (1)
shiny/render/_data_frame_utils/_tbl_data.py:211
- Consider adding tests to verify that the new Binary dtype branch in serialize_dtype serializes values correctly.
elif hasattr(nw, "Binary") and isinstance(
schloerke
approved these changes
Mar 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Narwhals#2243
is going to introduceintroducedBinarydtype, this PR adds support for that by serializingBinaryto"binary"