refactor: Add CompliantFrame protocol
#3056
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@FBruzzesi I know the lack of this has caused you a few headaches in the past 😉 |
8 tasks
This was referenced Oct 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Related issues
Compliant*APIs #3045CompliantColumn#2967Checklist
If you have comments or can explain your changes, please do so below
Beyond the changes/fixes here - the main candidate to use it for is in
BaseFramenarwhals/narwhals/dataframe.py
Lines 108 to 110 in 53bd16c
Might need some more tweaks first and waiting on (#3016) to land
... but it sure would be nice for the 300ish lines in
BaseFrameto have more complete typing 😄