fix/workaround: iOS video thumbnails in BlockVideo/BaseVideo#788
Open
stephiescastle wants to merge 1 commit intomainfrom
Open
fix/workaround: iOS video thumbnails in BlockVideo/BaseVideo#788stephiescastle wants to merge 1 commit intomainfrom
stephiescastle wants to merge 1 commit intomainfrom
Conversation
sfimbres
approved these changes
Dec 10, 2025
Contributor
sfimbres
left a comment
There was a problem hiding this comment.
LGTM!
Confirmed working on iPhone 16 simulator (Xcode)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Description
Native videos in
BlockVideodon't load a thumbnail on iOS. This is a workaround that ensures the first frame will be loaded.Important notes:
A couple notable reasons we may not want to merge this "fix":
Instructions to test
BlockVideohttp://localhost:6006/iframe.html?args=&globals=&id=components-blocks-blockvideo--base-story#/Tested in the following environments/browsers:
Operating System
Browser