Skip to content

fix/workaround: iOS video thumbnails in BlockVideo/BaseVideo#788

Open
stephiescastle wants to merge 1 commit intomainfrom
fix/block-video-thumbnail-ios
Open

fix/workaround: iOS video thumbnails in BlockVideo/BaseVideo#788
stephiescastle wants to merge 1 commit intomainfrom
fix/block-video-thumbnail-ios

Conversation

@stephiescastle
Copy link
Member

@stephiescastle stephiescastle commented Dec 10, 2025

Checklist

  • Include a description of your pull request and instructions for the reviewer to verify your work.
  • Link to the issue if this PR is issue-specific.
  • Create/update the corresponding story if this includes a UI component.
  • Create/update documentation. If not included, tell us why.
  • List the environments / browsers in which you tested your changes.
  • Tests, linting, or other required checks are passing.
  • PR has an informative and human-readable title
    • PR titles are used to generate the change log in releases; good ones make that easier to scan.
    • PRs will be broadly categorized in the change log, but for even easier scanning, consider prefixing with a component name or other useful categorization, e.g., "BaseButton: fix layout bug", or "Storybook: Update dependencies".
  • PR has been tagged with a SemVer label and a general category label, or skip-changelog.
    • These tags are used to do the aforementioned broad categorization in the change log and determine what the next release's version number should be.
    • Release Drafter will attempt to do the category labeling for you! Please double-check its work.

Description

Native videos in BlockVideo don't load a thumbnail on iOS. This is a workaround that ensures the first frame will be loaded.

Important notes:

A couple notable reasons we may not want to merge this "fix":

  • Note that iOS's behavior may be intentional for performance reasons.
  • if the video is super short, like a few seconds, the video jogger will look slightly advanced:
image

Instructions to test

  1. Use an iphone or iphone simulator (XCode) to view BlockVideo http://localhost:6006/iframe.html?args=&globals=&id=components-blocks-blockvideo--base-story#/
  2. There should be a thumbnail

Tested in the following environments/browsers:

Operating System

  • macOS
  • iOS
  • iPadOS
  • Windows

Browser

  • Chrome
  • Firefox ESR
  • Firefox
  • Safari
  • Edge

@github-actions github-actions bot added the bug Something isn't working label Dec 10, 2025
Copy link
Contributor

@sfimbres sfimbres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Confirmed working on iPhone 16 simulator (Xcode)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants