Skip to content

fix/workaround: iOS video thumbnails in BlockVideo/BaseVideo #788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stephiescastle wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix/workaround: iOS video thumbnails in BlockVideo/BaseVideo #788

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions packages/vue/src/components/BaseVideo/BaseVideo.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,19 +19,19 @@
>
<template v-if="data.fileWebm">
<source
:src="data.fileWebm"
:src="`${data.fileWebm}#t=0.1`"
type="video/webm"
/>
</template>
<template v-if="data.file">
<source
:src="data.file"
:src="`${data.file}#t=0.1`"
type="video/mp4"
/>
</template>
<template v-if="data.fileOgg">
<source
:src="data.fileOgg"
:src="`${data.fileOgg}#t=0.1`"
type="video/ogg"
/>
</template>
Expand All @@ -41,6 +41,10 @@
</div>
</template>
<script lang="ts">
/**
* Uses the Media Fragments URI (#t=0.1) to make sure iOS loads the first frame as a thumbnail
* TODO: remove #t=0.1 once we have implemented the video thumbnail/postcard
*/
import { defineComponent, type PropType } from 'vue'
import type { VideoObject } from './../../interfaces'
import BaseImagePlaceholder from './../BaseImagePlaceholder/BaseImagePlaceholder.vue'
Expand Down
Loading