Skip to content

spapadop/plt-862-fix-namespace-usage-in-rendered-manifest-files#26

Merged
spapa013 merged 1 commit intonauticalab:develop/spapadopfrom
spapa013:spapadop/plt-862-fix-namespace-usage-in-rendered-manifest-files
Mar 6, 2026
Merged

spapadop/plt-862-fix-namespace-usage-in-rendered-manifest-files#26
spapa013 merged 1 commit intonauticalab:develop/spapadopfrom
spapa013:spapadop/plt-862-fix-namespace-usage-in-rendered-manifest-files

Conversation

@spapa013
Copy link
Collaborator

@spapa013 spapa013 commented Mar 5, 2026

Summary

This PR fixes namespace propagation in rendered Kubernetes manifests.

Previously, setting namespace in config rendered a Namespace resource, but several namespaced resources did not include metadata.namespace, so they did not explicitly target the configured namespace.

What changed

  • Added metadata.namespace: {{.Namespace}} to all namespaced dev manifest templates:
    • statefulset
    • service (SSH + HTTP service docs in same template)
    • env-vars configmap
    • startup-scripts configmap
    • ingress
  • Updated template tests to include ingress in golden coverage.
  • Regenerated golden files, including new internal/templates/testdata/golden/ingress.yaml.

Why

Ensures all rendered namespaced resources are deployed into the configured namespace, matching the completion criteria for this issue.

Validation

  • Ran:
go test -v -race -covermode=atomic -coverprofile=./coverage.out ./...

Result: all tests passed.

  • manifests target correct namespace when applied

Notes

@spapa013 spapa013 requested a review from eywalker March 5, 2026 21:40
@spapa013 spapa013 changed the title Spapadop/plt 862 fix namespace usage in rendered manifest files spapadop/plt-862-fix-namespace-usage-in-rendered-manifest-files Mar 5, 2026
@codecov
Copy link

codecov bot commented Mar 5, 2026

Codecov Report

❌ Patch coverage is 71.42857% with 8 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
internal/config/validation.go 71.42% 5 Missing and 3 partials ⚠️

📢 Thoughts on this report? Let us know!

@spapa013 spapa013 changed the base branch from main to develop/spapadop March 6, 2026 19:28
@spapa013 spapa013 force-pushed the spapadop/plt-862-fix-namespace-usage-in-rendered-manifest-files branch from 6c12cc5 to bd48064 Compare March 6, 2026 19:53
@spapa013 spapa013 merged commit 49d81ae into nauticalab:develop/spapadop Mar 6, 2026
@spapa013 spapa013 mentioned this pull request Mar 6, 2026
@spapa013 spapa013 deleted the spapadop/plt-862-fix-namespace-usage-in-rendered-manifest-files branch March 6, 2026 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant