spapadop/plt-862-fix-namespace-usage-in-rendered-manifest-files#26
Merged
spapa013 merged 1 commit intonauticalab:develop/spapadopfrom Mar 6, 2026
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
6c12cc5 to
bd48064
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes namespace propagation in rendered Kubernetes manifests.
Previously, setting
namespacein config rendered aNamespaceresource, but several namespaced resources did not includemetadata.namespace, so they did not explicitly target the configured namespace.What changed
metadata.namespace: {{.Namespace}}to all namespaced dev manifest templates:statefulsetservice(SSH + HTTP service docs in same template)env-varsconfigmapstartup-scriptsconfigmapingressingressin golden coverage.internal/templates/testdata/golden/ingress.yaml.Why
Ensures all rendered namespaced resources are deployed into the configured namespace, matching the completion criteria for this issue.
Validation
go test -v -race -covermode=atomic -coverprofile=./coverage.out ./...Result: all tests passed.
Notes
Namespacebehavior is unchanged.