Make TinyURL usage opt-in and reduce unnecessary API calls#72
Merged
neesjanvaneck merged 4 commits intoneesjanvaneck:developfrom Jul 21, 2025
Merged
Conversation
Make shortlink optional as an Opt-In mechanism, thus unchecked in the UI per default until the user is enabling it.
In case inside the UI config the share icon is disabled, there is no need to render the <Share /> component. Thus conditionally rendering the component if enabled within the config.
Author
|
ok @neesjanvaneck in this PR I see the checkbox "Allow edits by maintainers" and checked it. 👍 |
Owner
|
Thanks @andi1984-ds! I have made some minor changes and will merge into the |
neesjanvaneck
added a commit
that referenced
this pull request
Jul 21, 2025
Co-authored-by: Nees Jan van Eck <36573334+neesjanvaneck@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @neesjanvaneck,
I'm Andi from the Dimensions team. We've been working with the Share functionality and have a couple of suggestions we believe could enhance it:
Please let me know if you have any questions or would like to discuss these points further. I'm happy to provide more details or hop on a call.
Best regards,
Andi
Updates to the
Sharecomponent:src/components/ui/Share/index.js: Changed the default state ofuseShortLinktofalse, making short links opt-in instead of enabled by default.Conditional rendering of the
Shareicon:src/pages/Dimensions/index.js: Added conditional rendering for theShareicon based on theuiConfig.share_iconflag inconfigStore.src/pages/VOSviewer/index.js: Updated theShareicon to render only if theuiConfig.share_iconflag is enabled.src/pages/ZetaAlpha/index.js: Modified the rendering of theShareicon to be conditional on theuiConfig.share_iconflag inconfigStore.