Skip to content

Comments

Make TinyURL usage opt-in and reduce unnecessary API calls#72

Merged
neesjanvaneck merged 4 commits intoneesjanvaneck:developfrom
andi1984-ds:fix/shortlink-opt-in
Jul 21, 2025
Merged

Make TinyURL usage opt-in and reduce unnecessary API calls#72
neesjanvaneck merged 4 commits intoneesjanvaneck:developfrom
andi1984-ds:fix/shortlink-opt-in

Conversation

@andi1984-ds
Copy link

Hi @neesjanvaneck,

I'm Andi from the Dimensions team. We've been working with the Share functionality and have a couple of suggestions we believe could enhance it:

  1. Conditional Rendering for the Component: We've noticed that even when sharing is disabled in the configuration, the component still renders, triggering its useEffect hook and making calls to services like tinyurl.com. We propose conditionally rendering the component so it doesn't mount at all if sharing is turned off. This would prevent unnecessary network requests.
  2. Opt-In Approach for Short URL Services: Currently, the TinyURL service is used by default. For greater transparency and to align with data privacy considerations like GDPR and FedRAMP compliance, we suggest making the use of short URL services an opt-in feature rather than opt-out.
    Please let me know if you have any questions or would like to discuss these points further. I'm happy to provide more details or hop on a call.

Best regards,

Andi

Updates to the Share component:

Conditional rendering of the Share icon:

Make shortlink optional as an Opt-In mechanism, thus unchecked in the UI per default until the user is enabling it.
In case inside the UI config the share icon is disabled, there is no need to render the <Share /> component. Thus conditionally rendering the component if enabled within the config.
@andi1984-ds
Copy link
Author

ok @neesjanvaneck in this PR I see the checkbox "Allow edits by maintainers" and checked it. 👍

@andi1984-ds andi1984-ds changed the title Share functionality and TinyURL usage (Peronal PR) Share functionality and TinyURL usage (Personal PR) Jul 21, 2025
@andi1984-ds andi1984-ds changed the title Share functionality and TinyURL usage (Personal PR) Share functionality and TinyURL usage Jul 21, 2025
@neesjanvaneck neesjanvaneck changed the base branch from master to develop July 21, 2025 20:15
@neesjanvaneck neesjanvaneck self-assigned this Jul 21, 2025
@neesjanvaneck neesjanvaneck changed the title Share functionality and TinyURL usage Make TinyURL usage opt-in and reduce unnecessary API calls Jul 21, 2025
@neesjanvaneck
Copy link
Owner

Thanks @andi1984-ds! I have made some minor changes and will merge into the develop branch shortly. The updates will be available in the master branch after the next release.

@neesjanvaneck neesjanvaneck merged commit 65ad8b4 into neesjanvaneck:develop Jul 21, 2025
1 check passed
neesjanvaneck added a commit that referenced this pull request Jul 21, 2025
Co-authored-by: Nees Jan van Eck <36573334+neesjanvaneck@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants