Skip to content

Make TinyURL usage opt-in and reduce unnecessary API calls #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
neesjanvaneck merged 4 commits into from
Jul 21, 2025
Merged

Make TinyURL usage opt-in and reduce unnecessary API calls #72

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c08b706
fix: Make shortlink optional as Opt-In mechanism
andi1984-ds Jun 3, 2025
6f09924
fix: Do not render Share component when Share config is disabled
andi1984-ds Jun 3, 2025
4c91d41
Do not render Share icon in React component context
neesjanvaneck Jul 21, 2025
20125d7
Clean up
neesjanvaneck Jul 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/ui/Share/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ const Share = observer(() => {
const uiStore = useContext(UiStoreContext);
const visualizationStore = useContext(VisualizationStoreContext);
const [isOpen, setIsOpen] = useState(false);
const [useShortLink, setUseShortLink] = useState(true);
const [useShortLink, setUseShortLink] = useState(false);
const [useCustomSettings, setUseCustomSettings] = useState(false);
const [link, setLink] = useState('');
const [embedCode, setEmbedCode] = useState('');
Expand Down
8 changes: 4 additions & 4 deletions src/pages/Dimensions/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,14 +120,14 @@ const Dimensions = observer(({ queryString = {}, fullscreenHandle }) => {
<>
<Open />
<Save />
<Share />
{!IS_REACT_COMPONENT && configStore.uiConfig.share_icon && <Share />}
<Screenshot />
</>
)}
<DarkLightTheme />
{!queryString.looker_ui && (
<Fullscreen enter={fullscreenHandle.enter} exit={fullscreenHandle.exit} active={fullscreenHandle.active} />
)}
{!queryString.looker_ui && (
<Fullscreen enter={fullscreenHandle.enter} exit={fullscreenHandle.exit} active={fullscreenHandle.active} />
)}
<Info />
</div>
<URLPanel />
Expand Down
2 changes: 1 addition & 1 deletion src/pages/VOSviewer/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ const VOSviewer = observer(({ queryString = {}, fullscreenHandle }) => {
<div className={`${s.actionIcons(configStore.urlPreviewPanelWidth)} ${configStore.urlPreviewPanel ? s.previewIsOpen : ''}`}>
<Open />
<Save />
<Share />
{!IS_REACT_COMPONENT && configStore.uiConfig.share_icon && <Share />}
<Screenshot />
<DarkLightTheme />
<Info />
Expand Down
2 changes: 1 addition & 1 deletion src/pages/ZetaAlpha/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ const ZetaAlpha = observer(({ queryString = {}, fullscreenHandle }) => {
<div className={`${s.actionIcons(configStore.urlPreviewPanelWidth)} ${configStore.urlPreviewPanel ? s.previewIsOpen : ''}`}>
<Open />
<Save />
<Share />
{!IS_REACT_COMPONENT && configStore.uiConfig.share_icon && <Share />}
<Screenshot />
<DarkLightTheme />
<Fullscreen enter={fullscreenHandle.enter} exit={fullscreenHandle.exit} active={fullscreenHandle.active} />
Expand Down