-
Notifications
You must be signed in to change notification settings - Fork 41
feat!: Remove formatter #247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
So the PHP CS Fixer package is not happy with the PHP version in CI so I updated it to latest. On doing that though, it suddenly started removing some PHPDoc params. See diff below /**
- * @param list<UnmanagedTransaction> $tsxs
- *
* @return list<UnmanagedTransaction>
*/
private function addTransactionOrRun(int $i, array $tsxs, int $retriesLeft = 10): array I tracked it down to |
4d1d3c3
to
4579b9f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff. I checked the code diff locally withoutthe cs changes and it looked great. I just pulled back in the tests from the OGM Formatter as they still apply in the summarized resultFormatter
54b4c80
to
1d2fadc
Compare
1d2fadc
to
be6a56c
Compare
Re opening this PR. I believe the HTTP removal PR (#244) was merged first, before merging #255. And since these were stacked PRs, #244 merged to main, then #255 merged to
feat/remove-http
but after it was merged to main so the code in #255 did not reach main at all