fix: implement missing getServerInfo method in SymfonyDriver#100
Merged
transistive merged 1 commit intoneo4j-php:masterfrom Jan 5, 2026
Merged
Conversation
SymfonyDriver was missing the getServerInfo() method required by DriverInterface, causing a fatal error when the class was loaded. Also fixed verifyConnectivity() - it wasn't passing $config parameter to the underlying driver. Closes neo4j-php#99 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
For everyone waiting this to get merged, it's working up to |
Collaborator
|
Thank you, everyone, for the fix. We will create a new release today, along with the updated docs. Happy New Year! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #99
Problem
SymfonyDriverimplementsDriverInterfacebut was missing thegetServerInfo()method, causing:Fatal Error: Class Neo4j\Neo4jBundle\Decorators\SymfonyDriver contains 1 abstract method
and must therefore be declared abstract or implement the remaining methods
(Laudis\Neo4j\Contracts\DriverInterface::getServerInfo)
This broke compatibility with
laudis/neo4j-php-client3.4.x which added this method to the interface.Changes
getServerInfo()method that delegates to the underlying driververifyConnectivity()- it wasn't passing the$configparameter (same bug pattern)SymfonyDriverNotes
The fix follows the existing decorator pattern used by other methods in this class. Both methods now correctly forward the optional
SessionConfigurationparameter.