Skip to content

User Auth Providers #1745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 62 commits into from
Sep 25, 2024
Merged

User Auth Providers #1745

merged 62 commits into from
Sep 25, 2024

Conversation

@phil198
Copy link
Contributor

@phil198 phil198 commented Jul 24, 2024 •
edited
Loading

This PR is for the examples and general description of the User Auth Providers feature. Its currently applicable to native auth, LDAP and OIDC.

@phil198 phil198 marked this pull request as draft July 24, 2024 15:47
@renetapopova renetapopova self-requested a review July 29, 2024 14:08
@renetapopova renetapopova self-assigned this Jul 31, 2024
@renetapopova renetapopova removed the 5.23 label Aug 1, 2024
@renetapopova renetapopova mentioned this pull request Aug 13, 2024
Merged
@phil198 phil198 force-pushed the linked-users branch 2 times, most recently from 0eb2389 to 63f5c35 Compare August 19, 2024 16:01
@phil198 phil198 marked this pull request as ready for review August 19, 2024 16:03
@phil198 phil198 changed the title linked users User Auth Objects Aug 20, 2024
Hunterness
Hunterness reviewed Aug 22, 2024
View reviewed changes
Copy link
Contributor

@Hunterness Hunterness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have only really looked at the generic and native auth parts so far, but I'll pause here for now as I've collected several comments already XD

Hunterness
Hunterness reviewed Aug 27, 2024
View reviewed changes
Copy link
Contributor

@Hunterness Hunterness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewing the review fixes

Hunterness
Hunterness reviewed Aug 27, 2024
View reviewed changes
Copy link
Contributor

@Hunterness Hunterness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments from the ldap page

@phil198 phil198 added 5.24 and removed 5.25 labels Aug 27, 2024
Hunterness
Hunterness reviewed Aug 27, 2024
View reviewed changes
Copy link
Contributor

@Hunterness Hunterness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments around the version label, most of which are reminders to make sure it is the correct version before merging

Hunterness
Hunterness reviewed Aug 27, 2024
View reviewed changes
Copy link
Contributor

@Hunterness Hunterness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments on sso-integration

phil198
phil198 commented Aug 27, 2024
View reviewed changes
@phil198 phil198 changed the title User Auth Objects User Auth Providers Aug 27, 2024
Hunterness
Hunterness reviewed Aug 28, 2024
View reviewed changes
Copy link
Contributor

@Hunterness Hunterness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found I forgot to post the comments on my review of the updates yesterday, did look over all the files I had previously looked at and added one more comment this morning but it might be a duplicate from yesterday (I didn't see it in the all commit view but I remember adding a comment like it at least so it might have either been on another row or the bit of code has moved or something between looking on yesterdays commits only and all commits 🤷)

Hunterness
Hunterness reviewed Aug 28, 2024
View reviewed changes
Copy link
Contributor

@Hunterness Hunterness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments from the last file, now all files have been looked at at least once

@renetapopova
Copy link
Collaborator

Hey @phil198, please let me know when this is ready for a review from my side.

@phil198
Copy link
Contributor Author

phil198 commented Sep 3, 2024

Hey @phil198, please let me know when this is ready for a review from my side.
Hi @renetapopova. Please go ahead when convenient. Or if you prefer, can wait till we've resolved the cypher-operations comments to make things simpler?

renetapopova and others added 11 commits September 24, 2024 10:20
@renetapopova @phil198
Update modules/ROOT/pages/authentication-authorization/auth-providers…
d509b3e 
….adoc

Co-authored-by: Phil Wright <[email protected]>
@renetapopova @phil198
Update modules/ROOT/pages/authentication-authorization/manage-users.adoc
95d1d02 
Co-authored-by: Phil Wright <[email protected]>
@renetapopova @phil198
Update modules/ROOT/pages/authentication-authorization/manage-users.adoc
6ea6053 
Co-authored-by: Phil Wright <[email protected]>
@renetapopova @phil198
Update modules/ROOT/pages/tutorial/tutorial-sso-configuration.adoc
70dfc13 
Co-authored-by: Phil Wright <[email protected]>
@renetapopova @phil198
Update modules/ROOT/pages/tutorial/tutorial-sso-configuration.adoc
9ffa139 
Co-authored-by: Phil Wright <[email protected]>
@renetapopova @phil198
Update modules/ROOT/pages/tutorial/tutorial-sso-configuration.adoc
a3fa746 
Co-authored-by: Phil Wright <[email protected]>
@renetapopova @phil198
Update modules/ROOT/pages/authentication-authorization/manage-users.adoc
98b573f 
Co-authored-by: Phil Wright <[email protected]>
@Hunterness @phil198
Update modules/ROOT/pages/authentication-authorization/manage-users.adoc
58bd7a2 
Co-authored-by: Phil Wright <[email protected]>
@renetapopova
add native to the manage users
cd8f489
@renetapopova
revert the set password change not required descriptions
5943694
@renetapopova
refer to the examples in the respective sections
4f56af7
Hunterness
Hunterness reviewed Sep 25, 2024
View reviewed changes
Hunterness
Hunterness reviewed Sep 25, 2024
View reviewed changes
Copy link
Contributor

@Hunterness Hunterness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And then we still need to update the SHOW CURRENT USER column table to also include that the password change required field is null if there is no native auth like we did for the SHOW USERS column table.

@neo-technology-commit-status-publisher
Copy link
Collaborator

neo-technology-commit-status-publisher commented Sep 25, 2024 •
edited
Loading

Thanks for the documentation updates.

The preview documentation has now been torn down - reopening this PR will republish it.

@renetapopova renetapopova merged commit fc7da99 into neo4j:dev Sep 25, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@b33f b33f b33f left review comments

@renetapopova renetapopova renetapopova left review comments

@Hunterness Hunterness Hunterness approved these changes

Assignees

@OliviaYtterbrink OliviaYtterbrink

@Hunterness Hunterness

@renetapopova renetapopova

Labels

5.24 team-cypher-operations

Milestone

No milestone