Skip to content

Conversation

@NataliaIvakina
Copy link
Collaborator

No description provided.

@NataliaIvakina NataliaIvakina changed the title Add new configuration settings for 2025.03 Add new configuration settings and update the default of server.metrics.filter Mar 12, 2025
|Valid values
a|A string.
|Default value
m|+++b''+++
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks weird on the page

Copy link
Collaborator Author

@NataliaIvakina NataliaIvakina Mar 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took this from the test results. We're tied to the code here, and users will see the same when they run 'SHOW SETTINGS' cmd.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Th actual AzbSettings has a blank string so that operations/test-config-settings.py:60 is doing something weird

    @Description(
            "Azure authority host endpoint (only required for certain methods of authentication, it should be specified in its full form - e.g., https://login.microsoftonline.com)")
    public static final Setting<String> authority_endpoint = newBuilder(
                    "dbms.integrations.cloud_storage.azb.authority_endpoint", STRING, "")
            .build();

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, you're right, the test is wrong 😄. The default has to be " ". I tested this in Neo4j 2025.03

Copy link
Contributor

@docrozza docrozza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look OK to me - apart form the weird floating b in the azb.authority_endpoint setting

@NataliaIvakina
Copy link
Collaborator Author

The missing config related to TLS certificates is covered in the PR #2165

@neo-technology-commit-status-publisher
Copy link
Collaborator

neo-technology-commit-status-publisher commented Mar 20, 2025

Thanks for the documentation updates.

The preview documentation has now been torn down - reopening this PR will republish it.

@NataliaIvakina NataliaIvakina merged commit de52148 into neo4j:dev Mar 20, 2025
6 of 7 checks passed
@NataliaIvakina NataliaIvakina deleted the dev-add-new-configs branch March 20, 2025 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants