-
Notifications
You must be signed in to change notification settings - Fork 83
Add new configuration settings and update the default of server.metrics.filter
#2180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
server.metrics.filter
| |Valid values | ||
| a|A string. | ||
| |Default value | ||
| m|+++b''+++ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks weird on the page
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I took this from the test results. We're tied to the code here, and users will see the same when they run 'SHOW SETTINGS' cmd.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Th actual AzbSettings has a blank string so that operations/test-config-settings.py:60 is doing something weird
@Description(
"Azure authority host endpoint (only required for certain methods of authentication, it should be specified in its full form - e.g., https://login.microsoftonline.com)")
public static final Setting<String> authority_endpoint = newBuilder(
"dbms.integrations.cloud_storage.azb.authority_endpoint", STRING, "")
.build();
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep, you're right, the test is wrong 😄. The default has to be " ". I tested this in Neo4j 2025.03
docrozza
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look OK to me - apart form the weird floating b in the azb.authority_endpoint setting
|
The missing config related to TLS certificates is covered in the PR #2165 |
|
Thanks for the documentation updates. The preview documentation has now been torn down - reopening this PR will republish it. |
No description provided.