Skip to content

Document errors implemented in 2025.01 #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 25 commits into from
Jan 28, 2025
Merged

Document errors implemented in 2025.01 #243

merged 25 commits into from
Jan 28, 2025

Conversation

@renetapopova
Copy link
Collaborator

No description provided.

@renetapopova renetapopova requested a review from Lojjs December 24, 2024 12:22
@Lojjs Lojjs self-assigned this Jan 7, 2025
Lojjs
Lojjs requested changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@Lojjs Lojjs left a comment •
edited by NataliaIvakina
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a bunch of smaller things.

There are also some additional new error codes, you could add too. Either as part of this PR or in a separate one after the others go in, if that is easier. 22G05 I think you have missed since it was in the standard-defined sheet, the rest have been added by @sherfert and @WilcoNeo during the holidays:

Not in docs

  • 22G05
  • 42I41
  • 42N62
  • 50N10
  • 50N13
  • 50N14
  • 50N15
  • 51N62
  • 52N22

Commented-out in docs

  • 22N65
  • 22N70
  • 22N73
  • 22N74
  • 22N75
  • 22N76

@Lojjs Lojjs mentioned this pull request Jan 13, 2025
Merged
dogofbrian
dogofbrian reviewed Jan 14, 2025
View reviewed changes
renetapopova
renetapopova commented Jan 14, 2025
View reviewed changes
renetapopova and others added 7 commits January 14, 2025 16:25
renetapopova
renetapopova commented Jan 14, 2025
View reviewed changes
Lojjs
Lojjs reviewed Jan 22, 2025
View reviewed changes
Copy link
Contributor

@Lojjs Lojjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had another look, found some minor things as usual

NataliaIvakina and others added 2 commits January 24, 2025 13:40
@NataliaIvakina @Lojjs
Update modules/ROOT/pages/errors/gql-errors.adoc
185a9e1 
Co-authored-by: Louise Berglund <[email protected]>
@NataliaIvakina @Lojjs
Fix typos
ba3e243 
Co-authored-by: Louise Berglund <[email protected]>
NataliaIvakina
NataliaIvakina reviewed Jan 24, 2025
View reviewed changes
NataliaIvakina
NataliaIvakina reviewed Jan 24, 2025
View reviewed changes
Lojjs
Lojjs approved these changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@Lojjs Lojjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now

@NataliaIvakina
Copy link
Collaborator

@renetapopova hey! I've resolved conflicts here. Could you take a final look? I think we can merge this PR

renetapopova
renetapopova commented Jan 27, 2025
View reviewed changes
Copy link
Collaborator Author

@renetapopova renetapopova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found some discrepancies with the codebase.

modules/ROOT/pages/errors/gql-errors.adoc
// Status description:: error: data exception - property uniqueness constraint violated. Property uniqueness constraint violated: `{ $reasons }`.
=== 22N80

Status description:: error: data exception - index entry conflict. Index entry conflict: `{ $value }`.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not for this PR, but the message is the same as the subcondition here. Not very informative.

@neo-technology-commit-status-publisher
Copy link
Collaborator

neo-technology-commit-status-publisher commented Jan 28, 2025 •
edited
Loading

Thanks for the documentation updates.

The preview documentation has now been torn down - reopening this PR will republish it.

@renetapopova renetapopova merged commit 76e8a4e into neo4j:dev Jan 28, 2025
4 checks passed
@renetapopova renetapopova deleted the dev-implemented-errors branch January 28, 2025 09:42
@Lojjs Lojjs mentioned this pull request Feb 4, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dogofbrian dogofbrian dogofbrian left review comments

@Lojjs Lojjs Lojjs approved these changes

@NataliaIvakina NataliaIvakina NataliaIvakina left review comments

Assignees

@Lojjs Lojjs

Labels

2025.01

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@renetapopova @NataliaIvakina @neo-technology-commit-status-publisher @dogofbrian @Lojjs