Skip to content

Conversation

@NataliaIvakina
Copy link
Collaborator

No description provided.

@NataliaIvakina NataliaIvakina changed the title Add first part of errors implemented in 2025.04 Add errors implemented in 2025.04 Apr 17, 2025
Copy link
Contributor

@Lojjs Lojjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a small wording change compared to the codebase, the rest looks fine

Copy link
Contributor

@Lojjs Lojjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is the last bigger docs PR for error codes, I did a check docs towards the codebase:

These are used in the codebase and needs documentation

  • 08N19
  • 08N20
  • 08N21
  • 22004
  • 22012
  • 42N0A
  • 42N3A
  • 42N3B
  • 42N3C
  • 50N18
  • 50N19
  • 50N20
  • 52N21

Apart from the ones above, we have some which are present in the codebase but unused. Before adding the internal procedure for docs testing we need to decide whether these should be cleaned up from codebase or documented. For those that are standard defined I think it is better to clean up as it is only a subset, users cannot get them right now and they are already defined in GQL standard. But I am not 100% sure about the Neo4j defined unused ones, for these we need to be careful so not codes are re-used

@Lojjs Lojjs mentioned this pull request Apr 28, 2025
@NataliaIvakina NataliaIvakina requested a review from Lojjs April 28, 2025 07:08
Copy link
Contributor

@Lojjs Lojjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! We also need to document the ones listed in the bigger message. But feel free to make a Trello card/separate PR for that

@neo4j-docops-agent
Copy link
Collaborator

neo4j-docops-agent commented Apr 28, 2025

Thanks for the documentation updates.

The preview documentation has now been torn down - reopening this PR will republish it.

@NataliaIvakina
Copy link
Collaborator Author

Looks good! We also need to document the ones listed in the bigger message. But feel free to make a Trello card/separate PR for that

Thank you, @Lojjs! I'll follow your advice 🙂 and open a new PR for those errors

@NataliaIvakina NataliaIvakina merged commit ba5cc44 into neo4j:dev Apr 28, 2025
4 checks passed
@NataliaIvakina NataliaIvakina deleted the dev-errors-2025-04 branch April 28, 2025 08:43
Copy link
Collaborator

@renetapopova renetapopova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@renetapopova
Copy link
Collaborator

😄 You've already merged it. Sorry!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants