Added examples of notifications connected to deprecated namespaces #394
Conversation
| + | ||
| [source,cypher] | ||
| ---- | ||
| RETURN coll.flatten() AS result |
There was a problem hiding this comment.
Also, this one, never heard of it.
There was a problem hiding this comment.
coll.flatten is in the pipeline to be implemented. Hopefully in 2025.11 as well. This notification shows when a used defined function shadows a builtin function that is in a deprecated namespace.
There was a problem hiding this comment.
Ah, I see. Then, we should make sure that this PR is merged after coll.flatten is implemented.
| RETURN coll.flatten() AS result | ||
| ---- | ||
| Description of the returned code:: | ||
| The namespace of the invoked user-defined function is deprecated and the function is shadowing an internal function. (coll.flatten) |
There was a problem hiding this comment.
There is also a table 15 further up with all possible descriptions for 01N00 where you could add these as well.
renetapopova
force-pushed
the
2025.x-namespace-deprecations
branch
from
54066db to
6b2e73c
Compare
|
This PR includes documentation updates Updated pages: |
| ---- | ||
| Description of the returned code:: | ||
| The namespace of the invoked function is deprecated. (point.function) | ||
| The namespace of the invoked user-defined function is deprecated. (point.function) |
There was a problem hiding this comment.
Are we allowed to change the neo4j codes' descriptions? As far as I know, this would be a breaking change.
There was a problem hiding this comment.
The descriptions should match the codebase. If we change them here, we need to change them there as well.
There was a problem hiding this comment.
Yes in this case it is fine because the description is brand new for this feature so it is not breaking for anyone yet to change it
There was a problem hiding this comment.
Thanks for committing my suggestions, @JoelBergstrand. However, we can only change the Status descriptions, and those changes should be reflected in the codebase as well. The docs should show what the user will see.
| ---- | ||
| Description of the returned code:: | ||
| The namespace of the invoked function is deprecated. (point.function) | ||
| The namespace of the invoked user-defined function is deprecated. (point.function) |
There was a problem hiding this comment.
The descriptions should match the codebase. If we change them here, we need to change them there as well.
|
@renetapopova, my mistake - I was sure I made the corresponding update in the code base as well. Will do it right away. PR |
4 participants
Added examples for three new deprecations