- 
                Notifications
    You must be signed in to change notification settings 
- Fork 35
Added examples of notifications connected to deprecated namespaces #394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Changes from all commits
00594f3
              347a443
              6b2e73c
              90b7db6
              File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | 
|---|---|---|
|  | @@ -1555,6 +1555,116 @@ The Unicode character `\u0085` is deprecated for unescaped identifiers and will | |
| ====== | ||
| ===== | ||
|  | ||
| .Deprecated function namespace | ||
| [.tabbed-example] | ||
| ===== | ||
| [.include-with-GQLSTATUS-code] | ||
| ====== | ||
| Query:: | ||
| + | ||
| [source,cypher] | ||
| ---- | ||
| RETURN point.function() AS result | ||
|         
                  JoelBergstrand marked this conversation as resolved.
              Show resolved
            Hide resolved | ||
| ---- | ||
|  | ||
| Returned GQLSTATUS code:: | ||
| 01N00 | ||
|  | ||
| Returned status description:: | ||
| warn: feature deprecated. | ||
| The namespace used by the user-defined function `point.function` is deprecated. | ||
|  | ||
| Suggestions for improvement:: | ||
| Change the namespace to a non-deprecated namespace e.g. `my.point.function` or `pointing.function`. | ||
|  | ||
| ====== | ||
| [.include-with-neo4j-code] | ||
| ====== | ||
| Query:: | ||
| + | ||
| [source,cypher] | ||
| ---- | ||
| RETURN point.function() AS result | ||
| ---- | ||
| Description of the returned code:: | ||
| The namespace of the invoked user-defined function is deprecated. (point.function) | ||
| There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Are we allowed to change the neo4j codes' descriptions? As far as I know, this would be a breaking change. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The descriptions should match the codebase. If we change them here, we need to change them there as well. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes in this case it is fine because the description is brand new for this feature so it is not breaking for anyone yet to change it | ||
| ====== | ||
| ===== | ||
|  | ||
| .Deprecated procedure namespace | ||
| [.tabbed-example] | ||
| ===== | ||
| [.include-with-GQLSTATUS-code] | ||
| ====== | ||
| Query:: | ||
| + | ||
| [source,cypher] | ||
| ---- | ||
| CALL point.procedure() AS result | ||
|         
                  renetapopova marked this conversation as resolved.
              Show resolved
            Hide resolved | ||
| RETURN result | ||
| ---- | ||
|  | ||
| Returned GQLSTATUS code:: | ||
| 01N00 | ||
|  | ||
| Returned status description:: | ||
| warn: feature deprecated. | ||
| The namespace used by the user-defined procedure `point.procedure` is deprecated. | ||
|  | ||
| Suggestions for improvement:: | ||
| Change the namespace to a non-deprecated namespace e.g. `my.point.procedure` or `pointing.procedure`. | ||
|  | ||
| ====== | ||
| [.include-with-neo4j-code] | ||
| ====== | ||
| Query:: | ||
| + | ||
| [source,cypher] | ||
| ---- | ||
| CALL point.procedure() AS result | ||
| RETURN result | ||
| ---- | ||
| Description of the returned code:: | ||
| The namespace of the called user-defined procedure is deprecated. (point.procedure) | ||
| ====== | ||
| ===== | ||
|  | ||
| .Shadowing built-in function | ||
| [.tabbed-example] | ||
| ===== | ||
| [.include-with-GQLSTATUS-code] | ||
| ====== | ||
| Query:: | ||
| + | ||
| [source,cypher] | ||
| ---- | ||
| RETURN coll.flatten() AS result | ||
| ---- | ||
|  | ||
| Returned GQLSTATUS code:: | ||
| 01N00 | ||
|  | ||
| Returned status description:: | ||
| warn: feature deprecated. | ||
| The namespace of the invoked user-defined function `coll.flatten` is deprecated and the function is shadowing an internal function. | ||
|  | ||
| Suggestions for improvement:: | ||
| Change the namespace to a non-deprecated namespace e.g. `my.coll.flatten` or `collection.flatten`. | ||
|  | ||
| ====== | ||
| [.include-with-neo4j-code] | ||
| ====== | ||
| Query:: | ||
| + | ||
| [source,cypher] | ||
| ---- | ||
| RETURN coll.flatten() AS result | ||
| There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Also, this one, never heard of it. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 
 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ah, I see. Then, we should make sure that this PR is merged after  | ||
| ---- | ||
| Description of the returned code:: | ||
| The namespace of the invoked user-defined function is deprecated and the function is shadowing an internal function. (coll.flatten) | ||
| There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There is also a table 15 further up with all possible descriptions for 01N00 where you could add these as well. | ||
| ====== | ||
| ===== | ||
|  | ||
| [#_deprecated-feature-with-replacement] | ||
| === Feature deprecated with a replacement | ||
|  | ||
|  | ||
Uh oh!
There was an error while loading. Please reload this page.