Skip to content

Fix workflow input injection vulnerability in test steps#522

Merged
riggi-alekaj merged 1 commit intodevfrom
patch-injection-vuln
Mar 13, 2026
Merged

Fix workflow input injection vulnerability in test steps#522
riggi-alekaj merged 1 commit intodevfrom
patch-injection-vuln

Conversation

@riggi-alekaj
Copy link
Collaborator

Addresses a high-severity Semgrep finding: workflow inputs (inputs.RELEASE, inputs.DOCKER_IMAGE_VERSION) were interpolated directly into run: steps, which could allow code injection and secret exfiltration.

  • Pass inputs.RELEASE and inputs.DOCKER_IMAGE_VERSION via env: blocks instead of inline in the script
  • Use double-quoted env vars in the run scripts (e.g. "$ISRELEASE_INPUT") so values are treated as data, not executable code

@riggi-alekaj riggi-alekaj requested a review from bfeshti as a code owner March 10, 2026 07:59
bfeshti
bfeshti previously approved these changes Mar 11, 2026
@riggi-alekaj riggi-alekaj dismissed bfeshti’s stale review March 11, 2026 08:56

The merge-base changed after approval.

@riggi-alekaj riggi-alekaj force-pushed the patch-injection-vuln branch 7 times, most recently from d48b197 to f91be89 Compare March 12, 2026 15:29
@riggi-alekaj riggi-alekaj force-pushed the patch-injection-vuln branch from f91be89 to 50a9bf0 Compare March 12, 2026 16:24
@riggi-alekaj riggi-alekaj requested a review from bfeshti March 13, 2026 07:42
@riggi-alekaj riggi-alekaj merged commit 4f39787 into dev Mar 13, 2026
18 checks passed
@bfeshti bfeshti deleted the patch-injection-vuln branch March 13, 2026 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants