Skip to content

Fix workflow input injection vulnerability in test steps #522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
riggi-alekaj merged 1 commit into from
Mar 13, 2026
Merged

Fix workflow input injection vulnerability in test steps #522

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 20 additions & 8 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,16 +253,19 @@ jobs:
run: go install github.com/gotesttools/gotestfmt/v2/cmd/gotestfmt@latest

- name: Run Enterprise Integration and Unit tests
env:
ISRELEASE_INPUT: ${{ inputs.RELEASE }}
DOCKER_IMAGE_VERSION_INPUT: ${{ inputs.DOCKER_IMAGE_VERSION }}
run: |
mkdir -p .kube
cat ${KUBECONFIG} > .kube/config
CURRENT_DIRECTORY=$(pwd)
export KUBECONFIG="${CURRENT_DIRECTORY}/.kube/config"
export IPS_PASS=$(gcloud auth print-access-token)
#inputs.RELEASE does not hold value when workflow_dispatch is not called
ISRELEASE=${{ inputs.RELEASE }}
ISRELEASE="$ISRELEASE_INPUT"
if [[ ${#ISRELEASE} != 0 ]]; then
export NEO4J_DOCKER_IMG="neo4j:${{ inputs.DOCKER_IMAGE_VERSION }}-enterprise"
export NEO4J_DOCKER_IMG="neo4j:$DOCKER_IMAGE_VERSION_INPUT-enterprise"
fi
echo "NEO4J_DOCKER_IMG=${NEO4J_DOCKER_IMG}"
echo "printing kubeconfig path $KUBECONFIG"
Expand Down Expand Up @@ -312,16 +315,19 @@ jobs:
run: go install github.com/gotesttools/gotestfmt/v2/cmd/gotestfmt@latest

- name: Run Community Integration and Unit tests
env:
ISRELEASE_INPUT: ${{ inputs.RELEASE }}
DOCKER_IMAGE_VERSION_INPUT: ${{ inputs.DOCKER_IMAGE_VERSION }}
run: |
mkdir -p .kube
cat ${KUBECONFIG} > .kube/config
CURRENT_DIRECTORY=$(pwd)
export KUBECONFIG="${CURRENT_DIRECTORY}/.kube/config"
export IPS_PASS=$(gcloud auth print-access-token)
#inputs.RELEASE does not hold value when workflow_dispatch is not called
ISRELEASE=${{ inputs.RELEASE }}
ISRELEASE="$ISRELEASE_INPUT"
if [[ ${#ISRELEASE} != 0 ]]; then
export NEO4J_DOCKER_IMG="neo4j:${{ inputs.DOCKER_IMAGE_VERSION }}"
export NEO4J_DOCKER_IMG="neo4j:$DOCKER_IMAGE_VERSION_INPUT"
fi
echo "NEO4J_DOCKER_IMG=${NEO4J_DOCKER_IMG}"
echo "printing kubeconfig path $KUBECONFIG"
Expand Down Expand Up @@ -371,6 +377,9 @@ jobs:
run: go install github.com/gotesttools/gotestfmt/v2/cmd/gotestfmt@latest

- name: Run Enterprise Integration and Unit tests for Red Hat
env:
ISRELEASE_INPUT: ${{ inputs.RELEASE }}
DOCKER_IMAGE_VERSION_INPUT: ${{ inputs.DOCKER_IMAGE_VERSION }}
run: |
mkdir -p .kube
cat ${KUBECONFIG} > .kube/config
Expand All @@ -379,9 +388,9 @@ jobs:
echo "printing kubeconfig path $KUBECONFIG"
export IPS_PASS=$(gcloud auth print-access-token)
#inputs.RELEASE does not hold value when workflow_dispatch is not called
ISRELEASE=${{ inputs.RELEASE }}
ISRELEASE="$ISRELEASE_INPUT"
if [[ ${#ISRELEASE} != 0 ]]; then
export NEO4J_DOCKER_IMG="neo4j:${{ inputs.DOCKER_IMAGE_VERSION }}-enterprise"
export NEO4J_DOCKER_IMG="neo4j:$DOCKER_IMAGE_VERSION_INPUT-enterprise"
fi
echo "NEO4J_DOCKER_IMG=${NEO4J_DOCKER_IMG}"
go test -json -v -timeout ${GO_TEST_TIMEOUT} ./internal/integration_tests/ 2>&1 | tee /tmp/gotest.log | gotestfmt
Expand Down Expand Up @@ -430,6 +439,9 @@ jobs:
run: go install github.com/gotesttools/gotestfmt/v2/cmd/gotestfmt@latest

- name: Run Community Integration and Unit tests for Red Hat
env:
ISRELEASE_INPUT: ${{ inputs.RELEASE }}
DOCKER_IMAGE_VERSION_INPUT: ${{ inputs.DOCKER_IMAGE_VERSION }}
run: |
mkdir -p .kube
cat ${KUBECONFIG} > .kube/config
Expand All @@ -438,9 +450,9 @@ jobs:
echo "printing kubeconfig path $KUBECONFIG"
export IPS_PASS=$(gcloud auth print-access-token)
#inputs.RELEASE does not hold value when workflow_dispatch is not called
ISRELEASE=${{ inputs.RELEASE }}
ISRELEASE="$ISRELEASE_INPUT"
if [[ ${#ISRELEASE} != 0 ]]; then
export NEO4J_DOCKER_IMG="neo4j:${{ inputs.DOCKER_IMAGE_VERSION }}"
export NEO4J_DOCKER_IMG="neo4j:$DOCKER_IMAGE_VERSION_INPUT"
fi
echo "NEO4J_DOCKER_IMG=${NEO4J_DOCKER_IMG}"
go test -json -v -timeout ${GO_TEST_TIMEOUT} ./internal/integration_tests/ 2>&1 | tee /tmp/gotest.log | gotestfmt
Expand Down
Loading