Minor fixes to PNGCompression #817
Merged
+7
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
October 10, 2025 11:06
…ression Add small value to avoid numerical issues
- When 3DGS is extended with additional properties, e.g. appearance embeddings, the sorting can be erroneous. In this case, we sort only predefined attributes for 3DGS (means, quats, scales, opacities, and sh0 if appearance embedding is not used in the model).
Using predefined sort keys
AIBluefisher
changed the title
liruilong940607
approved these changes
Jan 28, 2026
Collaborator
liruilong940607
left a comment
liruilong940607
left a comment
There was a problem hiding this comment.
LGTM! thanks for the fix!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
centroids_normbecomeNaN. Add a small value tominsto avoid the numerical issue.