Skip to content

Minor fixes to PNGCompression #817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
liruilong940607 merged 4 commits into from
Jan 28, 2026
+7 −2
Merged

Minor fixes to PNGCompression #817

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1e52a9c
Add small value to avoid numerical issues
Oct 10, 2025
2d365ab
Merge pull request #1 from AIBluefisher/AIBluefisher-small-value-comp…
Oct 10, 2025
6208e0d
Using predefined sort keys
Oct 14, 2025
f428822
Merge pull request #2 from AIBluefisher/patch-1
Oct 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion gsplat/compression/png_compression.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,6 +325,7 @@ def _compress_kmeans(
params: Tensor,
n_clusters: int = 65536,
quantization: int = 6,
eps: float = 1e-6,
verbose: bool = True,
**kwargs,
) -> Dict[str, Any]:
Expand All @@ -339,6 +340,7 @@ def _compress_kmeans(
params (Tensor): parameters to compress
n_clusters (int): number of K-means clusters
quantization (int): number of bits in quantization
eps (float, optional): small value to avoid numerical issues. Default to 1e-6.
verbose (bool, optional): Whether to print verbose information. Default to True.

Returns:
Expand All @@ -364,7 +366,7 @@ def _compress_kmeans(
labels = labels.detach().cpu().numpy()
centroids = kmeans.centroids.permute(1, 0)

mins = torch.min(centroids)
mins = torch.min(centroids) + eps
maxs = torch.max(centroids)
centroids_norm = (centroids - mins) / (maxs - mins)
centroids_norm = centroids_norm.detach().cpu().numpy()
Expand Down
5 changes: 4 additions & 1 deletion gsplat/compression/sort.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,10 @@ def sort_splats(splats: Dict[str, Tensor], verbose: bool = True) -> Dict[str, Te
n_sidelen = int(n_gs**0.5)
assert n_sidelen**2 == n_gs, "Must be a perfect square"

sort_keys = [k for k in splats if k != "shN"]
sort_keys = ["means", "quats", "scales", "opacities"]
if "sh0" in splats:
sort_keys.append("sh0")

params_to_sort = torch.cat([splats[k].reshape(n_gs, -1) for k in sort_keys], dim=-1)
shuffled_indices = torch.randperm(
params_to_sort.shape[0], device=params_to_sort.device
Expand Down