Add Frozen String Literal Magic Comment to tests#781
Merged
Conversation
tagliala
force-pushed
the
chore/fzs-non-production
branch
from
f1ead73 to
a69246a
Compare
Owner
|
LGTM, thanks! |
tagliala
force-pushed
the
chore/fzs-non-production
branch
from
a69246a to
a190f58
Compare
Collaborator
Author
|
Those environment variables can be conditionally enabled I guess, I'll do some other changes. Reverted to draft |
tagliala
force-pushed
the
chore/fzs-non-production
branch
2 times, most recently
from
cc965a7 to
dd9d2ce
Compare
Changes have been applied exclusively to non-production code. The updates were performed automatically using: ``` rubocop --only Style/FrozenStringLiteralComment,Layout/EmptyLineAfterMagicComment,Style/RedundantFreeze -Am test/**/*.rb ``` An additional modification was required to `RiotTestHelpers.char_split`, where the string is now duplicated before calling `String#force_encoding` to prevent errors related to modifying frozen strings. The CI received t: - Update the checkout action to v6 - Enable frozen string flags in RUBYOPT when testing against Ruby >= 3.0 Ref: - #780 - https://gist.github.com/fxn/bf4eed2505c76f4fca03ab48c43adc72
tagliala
force-pushed
the
chore/fzs-non-production
branch
from
dd9d2ce to
0e31499
Compare
Collaborator
Author
|
@nesquena ready for review, minimal change to the workflow. Apparently there is no ">=" for strings in CI. The change looks simple enough. I've checked that environment is being considered by commenting the |
Owner
|
Nice fix, looks good to me to merge! |
Collaborator
Author
|
Now it is production code turn, but I'll give a try hopefully tomorrow |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes have been applied exclusively to non-production code. The updates were
performed automatically using:
An additional modification was required to
RiotTestHelpers.char_split, wherethe string is now duplicated before calling
String#force_encodingto preventerrors related to modifying frozen strings.
The CI received t:
Ref: