Update prep_118_topology_edge_connections.py #604
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtarking
requested changes
Sep 23, 2025
| if any(sw['name'] == link['source_device'] for sw in topology_switches): | ||
| if "." in link['source_interface']: | ||
| self.kwargs['results']['failed'] = True | ||
| self.kwargs['results']['msg'] = "Sub interfaces not allowed to be used for edge connections" |
Collaborator
There was a problem hiding this comment.
Would this be better done in a rule to avoid failing in the middle of runtime?
Collaborator
Author
There was a problem hiding this comment.
looking at that instead
Collaborator
|
Removed ready for review and 0.5.1 labels since Matt is working on doing this in a rule instead |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s)
Related Collection Role
Related Data Model Element
Proposed Changes
Test Notes
Cisco NDFC Version
Checklist