Skip to content

Update prep_118_topology_edge_connections.py #604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Update prep_118_topology_edge_connections.py #604

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion plugins/action/common/prepare_plugins/prep_118_topology_edge_connections.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,10 @@ def prepare(self):
# management IP address from topology switches
topology_switches = model_data['vxlan']['topology']['switches']
for link in model_data['vxlan']['topology']['edge_connections']:
if any(sw['name'] == link['source_device'] for sw in topology_switches):
if "." in link['source_interface']:
self.kwargs['results']['failed'] = True
self.kwargs['results']['msg'] = "Sub interfaces not allowed to be used for edge connections"
Copy link
Collaborator

@mtarking mtarking Sep 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would this be better done in a rule to avoid failing in the middle of runtime?

Copy link
Collaborator Author

@mthurstocisco mthurstocisco Oct 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking at that instead

elif any(sw['name'] == link['source_device'] for sw in topology_switches):
found_switch = next((item for item in topology_switches if item["name"] == link['source_device']))
if found_switch.get('management').get('management_ipv4_address'):
link['source_device_ip'] = found_switch['management']['management_ipv4_address']
Expand Down