fix: update readme with installation notes for Angular 19 #223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for plugin-angular-universal-demo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
pieh
commented
Nov 19, 2024
Comment on lines
-35
to
-40
| Create a `netlify.toml` in the root of your project. Your file should include the plugins section below: | ||
| ### For Angular 19 | ||
|
|
||
| ```toml | ||
| [[plugins]] | ||
| package = "@netlify/angular-runtime" | ||
| ``` |
There was a problem hiding this comment.
This is no longer needed with autoinstallation in CLI
pieh
force-pushed
the
fix/update-readme-installation-configuration
branch
from
2f00248 to
fd97f0b
Compare
pieh
commented
Nov 19, 2024
Comment on lines
+123
to
+129
| // Example API endpoints can be defined here. | ||
| // Uncomment and define endpoints as necessary. | ||
| // const pathname = new URL(request.url).pathname; | ||
| // if (pathname = '/api/hello') { | ||
| // return Response.json({ message: 'Hello from the API' }); | ||
| // } | ||
|
|
There was a problem hiding this comment.
Taking a page from what Angular scaffolds with commented out example ( https://github.com/angular/angular-cli/blob/main/packages/schematics/angular/ssr/files/application-builder/server.ts.template#L17-L27 )
overall unrelated to rest of changes and can drop it from here
mrstork
reviewed
Nov 19, 2024
mrstork
reviewed
Nov 19, 2024
mrstork
reviewed
Nov 19, 2024
pieh
force-pushed
the
fix/update-readme-installation-configuration
branch
from
b086bb6 to
4a1e5ca
Compare
mrstork
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.