fix(types): improve type safety in command helpers #7852
Conversation
This commit improves the type safety of `src/utils/command-helpers.ts` by: - Adding a `boolean` type to the `noColors` parameter in `safeChalk`. - Adding `string` and `number` types to the parameters of `padLeft`. - Importing the `Option` type from `commander` to correctly type the `sortOptions` function parameters and adding defensive checks to handle potentially `undefined` properties at runtime. These changes eliminate three `@ts-expect-error` instances and strengthen the module's type safety and runtime robustness.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
serhalp
changed the title
This commit updates the import of the `Option` type from `commander` to be a type-only import, following a suggestion from the code review. This is a best practice that makes the dependency explicit as a type-only dependency.
serhalp
deleted the
jules/fix-types-in-command-helpers-5578713463807412304
branch
This submission improves type safety in
src/utils/command-helpers.tsby adding explicit types to three functions (safeChalk,padLeft, andsortOptions), resolving multiple@ts-expect-errorcomments and making the code more robust. The changes include importing theOptiontype fromcommanderand adding defensive checks for potentiallyundefinedproperties.PR created automatically by Jules for task 5578713463807412304 started by @serhalp