Skip to content

fix(types): improve type safety in command helpers #7852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
serhalp merged 4 commits into from
Jan 9, 2026
Merged

fix(types): improve type safety in command helpers #7852

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0b11038
feat: Improve type safety in command-helpers
google-labs-jules[bot] Jan 8, 2026
e45d539
chore: Use type-only import for commander Option
google-labs-jules[bot] Jan 8, 2026
db88d5e
Merge branch 'main' into jules/fix-types-in-command-helpers-557871346…
serhalp Jan 8, 2026
5cb90c5
Merge branch 'main' into jules/fix-types-in-command-helpers-557871346…
serhalp Jan 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions src/utils/command-helpers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import { format, inspect } from 'util'
import type { NetlifyAPI } from '@netlify/api'
import { getAPIToken } from '@netlify/dev-utils'
import { Chalk, type ChalkInstance as ChalkInstancePrimitiveType } from 'chalk'
import type { Option } from 'commander'
import WSL from 'is-wsl'
import terminalLink from 'terminal-link'

Expand All @@ -24,8 +25,7 @@ const argv = process.argv.slice(2)
* @param {boolean} noColors - disable chalk colors
* @return {ChalkInstancePrimitiveType} - default or custom chalk instance
*/
// @ts-expect-error TS(7006) FIXME: Parameter 'noColors' implicitly has an 'any' type.
const safeChalk = function (noColors) {
const safeChalk = function (noColors: boolean) {
if (noColors) {
const colorlessChalk = new Chalk({ level: 0 })
return colorlessChalk
Expand All @@ -44,8 +44,7 @@ export type ChalkInstance = ChalkInstancePrimitiveType
* @param {string} [filler]
* @returns {string}
*/
// @ts-expect-error TS(7006) FIXME: Parameter 'str' implicitly has an 'any' type.
export const padLeft = (str, count, filler = ' ') => str.padStart(str.length + count, filler)
export const padLeft = (str: string, count: number, filler = ' ') => str.padStart(str.length + count, filler)

const platform = WSL ? 'wsl' : os.platform()
const arch = os.arch() === 'ia32' ? 'x86' : os.arch()
Expand Down Expand Up @@ -77,13 +76,12 @@ export const BANG = process.platform === 'win32' ? '»' : '›'
* @example
* options.sort(sortOptions)
*/
// @ts-expect-error TS(7006) FIXME: Parameter 'optionA' implicitly has an 'any' type.
export const sortOptions = (optionA, optionB) => {
export const sortOptions = (optionA: Option, optionB: Option) => {
// base flags should be always at the bottom
if (BASE_FLAGS.has(optionA.long) || BASE_FLAGS.has(optionB.long)) {
if ((optionA.long && BASE_FLAGS.has(optionA.long)) || (optionB.long && BASE_FLAGS.has(optionB.long))) {
return -1
}
return optionA.long.localeCompare(optionB.long)
return (optionA.long ?? '').localeCompare(optionB.long ?? '')
}

// Poll Token timeout 5 Minutes
Expand Down
Loading