[release-1.10] NETOBSERV-2398: Hide Network Traffic tab for some resources when Loki is disabled

[openshift-cherrypick-robot]

This is an automated cherry-pick of #1047

/assign jotak

[openshift-ci-robot]

@openshift-cherrypick-robot: Ignoring requests to cherry-pick non-bug issues: NETOBSERV-2398

In response to this:

This is an automated cherry-pick of #1047

/assign jotak

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

Hi @openshift-cherrypick-robot. Thanks for your PR.

I'm waiting for a netobserv member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[codecov]

Codecov Report

❌ Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 53.20%. Comparing base (be7ac91) to head (fed83cc).
⚠️ Report is 1 commits behind head on release-1.10.

Files with missing lines	Patch %	Lines
web/src/components/netflow-traffic-tab.tsx	20.00%	4 Missing ⚠️

Additional details and impacted files

@@               Coverage Diff                @@
##           release-1.10    #1052      +/-   ##
================================================
- Coverage         53.22%   53.20%   -0.02%     
================================================
  Files               205      205              
  Lines             11110    11115       +5     
  Branches           1294     1295       +1     
================================================
+ Hits               5913     5914       +1     
- Misses             4685     4689       +4     
  Partials            512      512              

Flag	Coverage Δ
uitests	55.97% <20.00%> (-0.03%)	⬇️
unittests	47.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
web/src/components/netflow-traffic-tab.tsx	56.52% <20.00%> (-2.86%)	⬇️

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[Amoghrd]

/ok-to-test

[github-actions]

New image:
quay.io/netobserv/network-observability-console-plugin:a81e988

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=a81e988 make set-plugin-image

[Amoghrd]

@leandroberetta @jotak The Network Traffic page is disabled on pods but network traffic tab on all other components show need loki to be enabled error which was not seen on the main PR

[jotak]

@Amoghrd I think that's because you're on the "Traffic flows" tab, which normally you can't get into when Loki is disabled, except in the case where you were already on that tab before disabling loki.
So that's a bug indeed but not a regression - I can reproduce it that way:

• with loki enabled, go on traffic flows tab
• disable loki
• refresh

[Amoghrd]

Oh yeah, my bad. I think the default tab when I click on Network Traffic is "Traffic flows", I dont know if its because of localStorage or if default has been changed to that.
But yeah the tabs are working fine. Sorry for the false alarm, we can go ahead and merge this
/label qe-approved

[openshift-ci-robot]

@openshift-cherrypick-robot: This pull request references NETOBSERV-2398 which is a valid jira issue.

In response to this:

This is an automated cherry-pick of #1047

/assign jotak

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[jotak]

/lgtm
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jotak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jotak]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment