Skip to content

Conversation

@jpinsonneau
Copy link
Contributor

@jpinsonneau jpinsonneau commented Jan 15, 2026

Description

  • Fix loki NoIssue status report
  • Handle LokiWarning case

Dependencies

netobserv/network-observability-operator#2335

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

  • Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
  • Does this PR require product documentation?
    • If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
  • Does this PR require a product release notes entry?
    • If so, fill in "Release Note Text" in the JIRA.
  • Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
    • If so, make sure it is described in the JIRA ticket.
  • QE requirements (check 1 from the list):
    • Standard QE validation, with pre-merge tests unless stated otherwise.
    • Regression tests only (e.g. refactoring with no user-facing change).
    • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

@codecov
Copy link

codecov bot commented Jan 15, 2026

Codecov Report

❌ Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 52.69%. Comparing base (9f6f672) to head (28c9f5a).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
web/moduleMapper/dummy.tsx 0.00% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1194      +/-   ##
==========================================
- Coverage   52.73%   52.69%   -0.05%     
==========================================
  Files         210      210              
  Lines       11026    11036      +10     
  Branches     1398     1402       +4     
==========================================
  Hits         5815     5815              
- Misses       4658     4668      +10     
  Partials      553      553              
Flag Coverage Δ
uitests 54.86% <0.00%> (-0.07%) ⬇️
unittests 46.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
web/moduleMapper/dummy.tsx 28.09% <0.00%> (-2.54%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@openshift-ci openshift-ci bot removed the lgtm label Jan 16, 2026
@openshift-ci
Copy link

openshift-ci bot commented Jan 16, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from jotak. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jpinsonneau
Copy link
Contributor Author

@jotak I've added a fix for the blinking issues on top: 28c9f5a

@jotak
Copy link
Member

jotak commented Jan 16, 2026

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jan 16, 2026
@memodi
Copy link
Member

memodi commented Jan 16, 2026

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Jan 16, 2026
@memodi
Copy link
Member

memodi commented Jan 16, 2026

/ok-to-test

@github-actions
Copy link

New image:
quay.io/netobserv/network-observability-console-plugin:d0f081a

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=d0f081a make set-plugin-image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm ok-to-test To set manually when a PR is safe to test. Triggers image build on PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants