Skip to content

Conversation

@jpinsonneau
Copy link
Contributor

@jpinsonneau jpinsonneau commented Jan 15, 2026

Description

  • check LokiStack status conditions
  • also check components status

Examples:

image
    - lastTransitionTime: '2026-01-15T15:23:10Z'
      message: 'LokiStack components have issues [name: loki, namespace: netobserv]: Ingester has 1 pending pod(s): loki-ingester-1; Gateway has 2 pending pod(s): loki-gateway-bdc57846c-7b45v, loki-gateway-bdc57846c-jqqrc'
      reason: LokiStackComponentIssues
      status: 'True'
      type: LokiIssue
image
    - lastTransitionTime: '2026-01-15T15:44:51Z'
      message: 'LokiStack has issues [name: loki, namespace: netobserv]: Warning: The schema configuration does not contain the most recent schema version and needs an update; Degraded: Missing object storage secret'
      reason: LokiStackIssues
      status: 'True'
      type: LokiIssue
image
    - lastTransitionTime: '2026-01-15T16:05:26Z'
      message: ''
      reason: NoIssue
      status: 'False'
      type: LokiIssue
    - lastTransitionTime: '2026-01-15T16:05:26Z'
      message: 'LokiStack has warnings [name: loki, namespace: netobserv]: Warning: The schema configuration does not contain the most recent schema version and needs an update'
      reason: LokiStackWarnings
      status: 'True'
      type: LokiWarning
image

Dependencies

netobserv/network-observability-console-plugin#1194

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

  • Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
  • Does this PR require product documentation?
    • If so, make sure the JIRA epic is labeled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
  • Does this PR require a product release notes entry?
    • If so, fill in "Release Note Text" in the JIRA.
  • Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
    • If so, make sure it is described in the JIRA ticket.
  • QE requirements (check 1 from the list):
    • Standard QE validation, with pre-merge tests unless stated otherwise.
    • Regression tests only (e.g. refactoring with no user-facing change).
    • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

@openshift-ci
Copy link

openshift-ci bot commented Jan 15, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign jotak for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Jan 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.13%. Comparing base (f7fda5b) to head (e169092).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2335      +/-   ##
==========================================
+ Coverage   73.65%   74.13%   +0.48%     
==========================================
  Files          88       89       +1     
  Lines        9841     9930      +89     
==========================================
+ Hits         7248     7362     +114     
+ Misses       2156     2135      -21     
+ Partials      437      433       -4     
Flag Coverage Δ
unittests 74.13% <100.00%> (+0.48%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
internal/pkg/manager/status/loki.go 100.00% <100.00%> (ø)
internal/pkg/manager/status/status_manager.go 86.66% <100.00%> (+6.90%) ⬆️

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@memodi
Copy link
Member

memodi commented Jan 16, 2026

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Jan 16, 2026
@github-actions
Copy link

New images:

  • quay.io/netobserv/network-observability-operator:b7269ef
  • quay.io/netobserv/network-observability-operator-bundle:v0.0.0-sha-b7269ef
  • quay.io/netobserv/network-observability-operator-catalog:v0.0.0-sha-b7269ef

They will expire after two weeks.

To deploy this build:

# Direct deployment, from operator repo
IMAGE=quay.io/netobserv/network-observability-operator:b7269ef make deploy

# Or using operator-sdk
operator-sdk run bundle quay.io/netobserv/network-observability-operator-bundle:v0.0.0-sha-b7269ef

Or as a Catalog Source:

apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
  name: netobserv-dev
  namespace: openshift-marketplace
spec:
  sourceType: grpc
  image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-sha-b7269ef
  displayName: NetObserv development catalog
  publisher: Me
  updateStrategy:
    registryPoll:
      interval: 1m

}
}
lokiStack := &lokiv1.LokiStack{}
nsname := types.NamespacedName{Name: fc.Spec.Loki.LokiStack.Name, Namespace: fc.Spec.Namespace}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should it be using fc.Spec.Loki.LokiStack.Namespace instead?

Suggested change
nsname := types.NamespacedName{Name: fc.Spec.Loki.LokiStack.Name, Namespace: fc.Spec.Namespace}
nsname := types.NamespacedName{Name: fc.Spec.Loki.LokiStack.Name, Namespace: fc.Spec.Loki.LokiStack.Namespace}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it should be conditional if LokiStack.Namespace is omitted then it should fallback on fc.Spec.Namespace.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm ok-to-test To set manually when a PR is safe to test. Triggers image build on PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants