Skip to content

Conversation

jpinsonneau
Copy link
Contributor

@jpinsonneau jpinsonneau commented Oct 9, 2024

Description

Postpone tick if drawer not rendered

This bug was introduced by #558

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

  • Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
  • Does this PR require product documentation?
    • If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
  • Does this PR require a product release notes entry?
    • If so, fill in "Release Note Text" in the JIRA.
  • Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
    • If so, make sure it is described in the JIRA ticket.
  • QE requirements (check 1 from the list):
    • Standard QE validation, with pre-merge tests unless stated otherwise.
    • Regression tests only (e.g. refactoring with no user-facing change).
    • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

@jpinsonneau jpinsonneau changed the title NETOBSERV-1871 NETOBSERV-1871 First request to get flow data waits indefinitely on workloads network-traffic page Oct 9, 2024
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 55.97%. Comparing base (cc0c6c0) to head (d852e0c).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
web/src/components/netflow-traffic.tsx 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #615      +/-   ##
==========================================
- Coverage   56.00%   55.97%   -0.03%     
==========================================
  Files         193      193              
  Lines        9482     9486       +4     
  Branches     1214     1215       +1     
==========================================
  Hits         5310     5310              
- Misses       3795     3799       +4     
  Partials      377      377              
Flag Coverage Δ
uitests 57.66% <0.00%> (-0.04%) ⬇️
unittests 51.32% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
web/src/components/netflow-traffic.tsx 68.06% <0.00%> (-0.78%) ⬇️

@Amoghrd
Copy link
Member

Amoghrd commented Oct 9, 2024

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Oct 9, 2024
Copy link

github-actions bot commented Oct 9, 2024

New image:
quay.io/netobserv/network-observability-console-plugin:1c69669

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=1c69669 make set-plugin-image

@Amoghrd
Copy link
Member

Amoghrd commented Oct 9, 2024

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved QE has approved this pull request label Oct 9, 2024
@Amoghrd
Copy link
Member

Amoghrd commented Oct 10, 2024

/approve

@Amoghrd
Copy link
Member

Amoghrd commented Oct 10, 2024

@jpinsonneau This PR is not yet merged. Could you add approve label

@jotak
Copy link
Member

jotak commented Oct 10, 2024

/approve

Copy link

openshift-ci bot commented Oct 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Amoghrd, jotak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit b7fdf62 into netobserv:main Oct 10, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. qe-approved QE has approved this pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants