Skip to content

Conversation

jotak
Copy link
Member

@jotak jotak commented Oct 10, 2024

We're seeing a lot of errors with "no message found". This is because with Loki operator 6, the json of the error has changed. We need now to look at the "error" field.

Also add more debug logs

We're seeing a lot of errors with "no message found". This is because
with Loki operator 6, the json of the error has changed. We need now to
look at the "error" field.

Also add more debug logs
@jotak jotak added no-qe This PR doesn't necessitate QE approval no-doc This PR doesn't require documentation change on the NetObserv operator labels Oct 10, 2024
@jotak jotak requested a review from jpinsonneau October 10, 2024 11:21
Copy link

openshift-ci bot commented Oct 10, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from jotak. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Oct 10, 2024

Codecov Report

Attention: Patch coverage is 28.57143% with 5 lines in your changes missing coverage. Please review.

Project coverage is 55.99%. Comparing base (693d236) to head (9c2ded5).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
pkg/handler/loki.go 28.57% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #617      +/-   ##
==========================================
- Coverage   56.01%   55.99%   -0.03%     
==========================================
  Files         193      193              
  Lines        9479     9487       +8     
  Branches     1213     1214       +1     
==========================================
+ Hits         5310     5312       +2     
- Misses       3792     3798       +6     
  Partials      377      377              
Flag Coverage Δ
uitests 57.70% <ø> (-0.03%) ⬇️
unittests 51.30% <28.57%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
pkg/handler/loki.go 40.00% <28.57%> (ø)

... and 3 files with indirect coverage changes

@jotak jotak merged commit 3d8481a into netobserv:main Oct 10, 2024
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-doc This PR doesn't require documentation change on the NetObserv operator no-qe This PR doesn't necessitate QE approval

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants