NETOBSERV-2098: Unified-perspectives #719
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@jpinsonneau could you rebase here please? |
jpinsonneau
force-pushed
the
unified-perspectives
branch
from
35ea650 to
efcad4b
Compare
sure, here we go ! |
|
/retest |
jpinsonneau
force-pushed
the
unified-perspectives
branch
from
b4534aa to
ad75014
Compare
jotak
changed the title
|
@jpinsonneau: This pull request references NETOBSERV-2098 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/ok-to-test |
openshift-ci
bot
added
the
ok-to-test
|
New image: It will expire after two weeks. To deploy this build, run from the operator repo, assuming the operator is running: USER=netobserv VERSION=8875510 make set-plugin-image |
jpinsonneau
force-pushed
the
unified-perspectives
branch
from
b5126f7 to
3aeaa32
Compare
github-actions
bot
removed
the
ok-to-test
|
/ok-to-test |
openshift-ci
bot
added
the
ok-to-test
|
New image: It will expire after two weeks. To deploy this build, run from the operator repo, assuming the operator is running: USER=netobserv VERSION=042225a make set-plugin-image |
@jpinsonneau - I am curious why bar namespace filter was added here? I know in past we used project in URL, but I am wondering if there could be no differences in views whether user is admin or developer and each user would see the flows for the namespaces they have access to 🤔 |
Ideally yes. However when querying to prometheus, endpoints are differents between admin and developers: We could run multiple queries in parallel and reconcile the results in the plugin to have a seamless experience but it could be heavy depending on how many namespaces the user have access to. |
ah, yes, thanks for refreshing my memory there. |
|
@jpinsonneau this may be unrelated, but could we add deterministic test-ids for "Advanced Configuration" toggles in the form menu: |
Sure ! is it the only one you need ? |
I think there are 4 such toggles in flowcollector form, one for each plugin, processor and ebpf agent and last one for exporters. 
feel free to add in this PR or create a separate whichever one you prefer. |
oh that's on the form view. It's not implemented on our side yet as we rely on the console implementation. |
| .then(role => { | ||
| let namespace = this.state.namespace; | ||
| if (role === 'dev') { | ||
| namespace = window?.sessionStorage?.getItem('bridge/last-namespace-name') || 'default'; |
There was a problem hiding this comment.
what's this 'bridge/last-namespace-name' ? Isn't it specific to running in dev mode with the bridge?
There was a problem hiding this comment.
That's coming from:
https://github.com/openshift/console/blob/57a4cdec7c9b5c24481efc279794f2208cc25c74/frontend/packages/console-shared/src/constants/common.ts#L43C57-L43C71
Bridge prefix is used for various items available in both dev and admin perspectives:
https://github.com/search?q=repo%3Aopenshift/console%20STORAGE_PREFIX&type=code
There is even a hook but not available in the console shared package:
https://github.com/openshift/console/blob/main/frontend/packages/console-app/src/components/detect-namespace/useLastNamespace.ts#L7
|
New image: It will expire after two weeks. To deploy this build, run from the operator repo, assuming the operator is running: USER=netobserv VERSION=8c5c793 make set-plugin-image |
|
/label qe-approved |
|
@jpinsonneau: This pull request references NETOBSERV-2098 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
I'm finding a couple of issues with multi-tenancy, although I'm not sure if this is related to this PR or if it's regressions with 4.19 more generally.
I'll open a separate ticket for the first point |
|
/retest |
|
@jpinsonneau: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@jpinsonneau yes, fine by me. |
5 participants
Description
Add namespace bar on top of the page when the user doesn't have the admin role.
The page will act as same as in the developer perspective in that case.
For admins, the selector is not showing.
Dependencies
based on #658
Checklist
If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.