-
Notifications
You must be signed in to change notification settings - Fork 41
NETOBSERV-2447: disable static plugin in compat mode #2092
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@jotak: This pull request references NETOBSERV-2447 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.21.0" version, but no target version was set. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/cherry-pick release-1.10 |
@jotak: once the present PR merges, I will cherry-pick it on top of In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
New images:
They will expire after two weeks. To deploy this build: # Direct deployment, from operator repo
IMAGE=quay.io/netobserv/network-observability-operator:c5e9a17 make deploy
# Or using operator-sdk
operator-sdk run bundle quay.io/netobserv/network-observability-operator-bundle:v0.0.0-sha-c5e9a17 Or as a Catalog Source: apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
name: netobserv-dev
namespace: openshift-marketplace
spec:
sourceType: grpc
image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-sha-c5e9a17
displayName: NetObserv development catalog
publisher: Me
updateStrategy:
registryPoll:
interval: 1m |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2092 +/- ##
==========================================
- Coverage 71.87% 71.79% -0.08%
==========================================
Files 80 80
Lines 10723 10733 +10
==========================================
- Hits 7707 7706 -1
- Misses 2615 2622 +7
- Partials 401 405 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jotak
when I deploy from above catalog, I still see static plugin pod in CLBO:
Server Version: 4.14.0-0.nightly-2025-10-12-145308
$ build_info.sh
OCP: 4.14.0-0.nightly-2025-10-12-145308
NetObserv operator: v0.0.0-sha-c5e9a17
Loki: 0-click-loki
Operator image: CREATED_DATE: "2025-10-13T10:20:52.497246533Z", tag: c5e9a17
eBPF-agent: CREATED_DATE: "2025-10-06T07:44:58.921883688Z", tag: main
FLP: CREATED_DATE: "2025-10-13T08:51:12.479290352Z", tag: main
ConsolePlugin: CREATED_DATE: "2025-10-09T15:59:49.474194559Z", tag: main
$ oc get pods -n openshift-netobserv-operator
NAME READY STATUS RESTARTS AGE
netobserv-controller-manager-6d665ddc59-x7rrb 1/1 Running 0 8m13s
netobserv-plugin-static-664cb64c6c-4k9wm 0/1 CrashLoopBackOff 6 (2m3s ago) 7m53s
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
New images:
They will expire after two weeks. To deploy this build: # Direct deployment, from operator repo
IMAGE=quay.io/netobserv/network-observability-operator:61f0f8c make deploy
# Or using operator-sdk
operator-sdk run bundle quay.io/netobserv/network-observability-operator-bundle:v0.0.0-sha-61f0f8c Or as a Catalog Source: apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
name: netobserv-dev
namespace: openshift-marketplace
spec:
sourceType: grpc
image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-sha-61f0f8c
displayName: NetObserv development catalog
publisher: Me
updateStrategy:
registryPoll:
interval: 1m |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/label qe-approved
@jotak: This pull request references NETOBSERV-2447 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.21.0" version, but no target version was set. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
No description provided.