Skip to content

Conversation

jotak
Copy link
Member

@jotak jotak commented Oct 13, 2025

No description provided.

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Oct 13, 2025

@jotak: This pull request references NETOBSERV-2447 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.21.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jotak
Copy link
Member Author

jotak commented Oct 13, 2025

/cherry-pick release-1.10

@openshift-cherrypick-robot

@jotak: once the present PR merges, I will cherry-pick it on top of release-1.10 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added the lgtm label Oct 13, 2025
@jotak jotak added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Oct 13, 2025
Copy link

New images:

  • quay.io/netobserv/network-observability-operator:c5e9a17
  • quay.io/netobserv/network-observability-operator-bundle:v0.0.0-sha-c5e9a17
  • quay.io/netobserv/network-observability-operator-catalog:v0.0.0-sha-c5e9a17

They will expire after two weeks.

To deploy this build:

# Direct deployment, from operator repo
IMAGE=quay.io/netobserv/network-observability-operator:c5e9a17 make deploy

# Or using operator-sdk
operator-sdk run bundle quay.io/netobserv/network-observability-operator-bundle:v0.0.0-sha-c5e9a17

Or as a Catalog Source:

apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
  name: netobserv-dev
  namespace: openshift-marketplace
spec:
  sourceType: grpc
  image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-sha-c5e9a17
  displayName: NetObserv development catalog
  publisher: Me
  updateStrategy:
    registryPoll:
      interval: 1m

Copy link

codecov bot commented Oct 13, 2025

Codecov Report

❌ Patch coverage is 27.27273% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.79%. Comparing base (431ac96) to head (868f6fb).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...r/consoleplugin/consoleplugin_static_reconciler.go 27.27% 5 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2092      +/-   ##
==========================================
- Coverage   71.87%   71.79%   -0.08%     
==========================================
  Files          80       80              
  Lines       10723    10733      +10     
==========================================
- Hits         7707     7706       -1     
- Misses       2615     2622       +7     
- Partials      401      405       +4     
Flag Coverage Δ
unittests 71.79% <27.27%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...r/consoleplugin/consoleplugin_static_reconciler.go 56.45% <27.27%> (-7.01%) ⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@memodi memodi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jotak
when I deploy from above catalog, I still see static plugin pod in CLBO:

Server Version: 4.14.0-0.nightly-2025-10-12-145308

$ build_info.sh
OCP: 4.14.0-0.nightly-2025-10-12-145308
NetObserv operator: v0.0.0-sha-c5e9a17
Loki: 0-click-loki
Operator image: CREATED_DATE: "2025-10-13T10:20:52.497246533Z", tag: c5e9a17
eBPF-agent: CREATED_DATE: "2025-10-06T07:44:58.921883688Z", tag: main
FLP: CREATED_DATE: "2025-10-13T08:51:12.479290352Z", tag: main
ConsolePlugin: CREATED_DATE: "2025-10-09T15:59:49.474194559Z", tag: main

$ oc get pods -n openshift-netobserv-operator
NAME                                            READY   STATUS             RESTARTS       AGE
netobserv-controller-manager-6d665ddc59-x7rrb   1/1     Running            0              8m13s
netobserv-plugin-static-664cb64c6c-4k9wm        0/1     CrashLoopBackOff   6 (2m3s ago)   7m53s

@openshift-ci openshift-ci bot removed the lgtm label Oct 13, 2025
@github-actions github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Oct 13, 2025
Copy link

openshift-ci bot commented Oct 13, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from jpinsonneau. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jotak jotak added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Oct 13, 2025
Copy link

New images:

  • quay.io/netobserv/network-observability-operator:61f0f8c
  • quay.io/netobserv/network-observability-operator-bundle:v0.0.0-sha-61f0f8c
  • quay.io/netobserv/network-observability-operator-catalog:v0.0.0-sha-61f0f8c

They will expire after two weeks.

To deploy this build:

# Direct deployment, from operator repo
IMAGE=quay.io/netobserv/network-observability-operator:61f0f8c make deploy

# Or using operator-sdk
operator-sdk run bundle quay.io/netobserv/network-observability-operator-bundle:v0.0.0-sha-61f0f8c

Or as a Catalog Source:

apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
  name: netobserv-dev
  namespace: openshift-marketplace
spec:
  sourceType: grpc
  image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-sha-61f0f8c
  displayName: NetObserv development catalog
  publisher: Me
  updateStrategy:
    registryPoll:
      interval: 1m

Copy link
Member

@memodi memodi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/label qe-approved

@openshift-ci openshift-ci bot added qe-approved QE has approved this pull request lgtm labels Oct 13, 2025
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Oct 13, 2025

@jotak: This pull request references NETOBSERV-2447 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.21.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference lgtm ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. qe-approved QE has approved this pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants