Skip to content

NETOBSERV-2447: disable static plugin in compat mode #2092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 14, 2025
Merged

NETOBSERV-2447: disable static plugin in compat mode #2092

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
86be79e
NETOBSERV-2447: disable static plugin in compat mode
jotak Oct 13, 2025
868f6fb
make sure cluster info is fetched
jotak Oct 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion internal/controller/consoleplugin/consoleplugin_static_reconciler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,14 @@ func (r *CPReconciler) reconcileStatic(ctx context.Context, desired *flowslatest
l := log.FromContext(ctx).WithName("console-plugin")
ctx = log.IntoContext(ctx, l)

// Skip static reconciler on older OpenShift (feature not implemented)
less415, err := r.ClusterInfo.IsOpenShiftVersionLessThan("4.15.0")
if err != nil && less415 {
return nil
}

// Retrieve current owned objects
err := r.Managed.FetchAll(ctx)
err = r.Managed.FetchAll(ctx)
if err != nil {
return err
}
Expand Down