Skip to content

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #2092

/assign jotak

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Oct 14, 2025

@openshift-cherrypick-robot: Ignoring requests to cherry-pick non-bug issues: NETOBSERV-2447

In response to this:

This is an automated cherry-pick of #2092

/assign jotak

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link

openshift-ci bot commented Oct 14, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign msherif1234 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

openshift-ci bot commented Oct 14, 2025

Hi @openshift-cherrypick-robot. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented Oct 14, 2025

Codecov Report

❌ Patch coverage is 27.27273% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.64%. Comparing base (02de4f3) to head (dbe8683).
⚠️ Report is 1 commits behind head on release-1.10.

Files with missing lines Patch % Lines
...r/consoleplugin/consoleplugin_static_reconciler.go 27.27% 5 Missing and 3 partials ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.10    #2094      +/-   ##
================================================
- Coverage         71.69%   71.64%   -0.05%     
================================================
  Files                80       80              
  Lines             10711    10721      +10     
================================================
+ Hits               7679     7681       +2     
- Misses             2626     2631       +5     
- Partials            406      409       +3     
Flag Coverage Δ
unittests 71.64% <27.27%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...r/consoleplugin/consoleplugin_static_reconciler.go 56.45% <27.27%> (-7.01%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jotak jotak merged commit 852e94e into netobserv:release-1.10 Oct 14, 2025
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants