fix(deps): resolve minimatch ReDoS vulnerability#482
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses critical security vulnerabilities by updating the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request aims to resolve ReDoS vulnerabilities in the transitive dependency minimatch by adding a yarn resolution. My review identifies a significant risk with the current approach: it forces a major version upgrade on a transitive dependency (typedoc), which could lead to unexpected breakages. I've provided a comment explaining this risk and suggesting a safer alternative. I've also added a recommendation to pin the dependency version in the resolution for more deterministic builds.
4695fd8 to
71dfa82
Compare
There was a problem hiding this comment.
Pull request overview
This PR addresses reported minimatch ReDoS vulnerabilities by forcing minimatch to a patched version via Yarn resolutions, updating the lockfile accordingly.
Changes:
- Add a Yarn
resolutionsoverride forminimatchinpackage.json. - Update
yarn.lockso minimatch resolves to10.2.4and removes now-unneeded transitive entries.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| package.json | Adds resolutions to enforce a patched minimatch version. |
| yarn.lock | Updates resolved minimatch version and related transitive dependency entries. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary
resolutionsto forceminimatch >=9.0.7, resolving both Dependabot alerts:^10.2.1via eslint (patched in 10.2.3)^9.0.5via typedoc (patched in 9.0.7)minimatch@10.2.4(covers both ranges)Test plan
yarn test— 75 tests passyarn lint— cleanyarn build:lib— builds clean