[Tests] Mock Observers, Static Lifecycle Tests #482
+556
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylesayrs
force-pushed
the
kylesayrs/refactor-initialize-tests
branch
from
97a4d16 to
0fdfbd1
Compare
Signed-off-by: Kyle Sayers <[email protected]>
Signed-off-by: Kyle Sayers <[email protected]>
Signed-off-by: Kyle Sayers <[email protected]>
Signed-off-by: Kyle Sayers <[email protected]>
Signed-off-by: Kyle Sayers <[email protected]>
Signed-off-by: Kyle Sayers <[email protected]>
Signed-off-by: Kyle Sayers <[email protected]>
kylesayrs
force-pushed
the
kylesayrs/refactor-initialize-tests
branch
from
0fdfbd1 to
8973328
Compare
Signed-off-by: Kyle Sayers <[email protected]>
| } | ||
|
|
||
|
|
||
| class ObserverBase(torch.nn.Module): |
There was a problem hiding this comment.
Why do we need mock ObserverBase and MockMovingMinMaxObserver? If the test asserts they arrive at an expected value, shouldn't we just be using and testing the real things?
There was a problem hiding this comment.
Good point, I’ll remove the extra classes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose