Pin setuptools lower bound to >v64 #141
Conversation
|
Hi @richarddushime, could you just update the tests? It should just be this line: |
|
Sorry there seems to be something else failing, would you mind taking a look? |
sure , I will take a look later. |
…-scm), not an underscore.
|
The package name for setuptools-scm on PyPI uses a hyphen (setuptools-scm), not an underscore. Please correct me if am wrong but basing on the latest package we are supposed to use a hyphen and underscore i saw it in older versions |
adamltyson
left a comment
adamltyson
left a comment
There was a problem hiding this comment.
Look good, thanks @richarddushime. Just one question.
| "setuptools>=64", | ||
| "wheel", | ||
| "setuptools_scm[toml]>=6.2", | ||
| "setuptools-scm[toml]>=8", |
There was a problem hiding this comment.
Is there a reason for enforcing this version?
There was a problem hiding this comment.
This project supports Python3 and specificallly 3.11+ and based on the documentation on Pypi 6.2 has lower versions check programing languages Tab.
looking at the 8 Programming Language Tab exactly uses what this projects supports and This ensures good TOML configuration and fewer legacy issues.
There was a problem hiding this comment.
If there is something i am missing out , please let me know , I will update it, but this is based on what i am reading in the code so far.
2 participants
Before submitting a pull request (PR), please read the contributing guide.
Please fill out as much of this template as you can, but if you have any problems or questions, just leave a comment and we will help out :)
Description
What is this PR
Why is this PR needed?
setuptools>=64: Addresses the editable install issue by setting the lower bound to v64
What does this PR do?
updates setup tools version
References
#136
How has this PR been tested?
Please explain how any new code has been tested, and how you have ensured that no existing functionality has changed.
Is this a breaking change?
If this PR breaks any existing functionality, please explain how and why.
Does this PR require an update to the documentation?
If any features have changed, or have been added. Please explain how the
documentation has been updated.
Checklist: