Skip to content

Pin setuptools lower bound to >v64 #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 24, 2025
Merged

Pin setuptools lower bound to >v64 #141

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
dae7ae6
Pin setuptools lower bound to >v64
richarddushime Mar 20, 2025
a8305fc
update tests
richarddushime Mar 20, 2025
a7ed542
The package name for setuptools-scm on PyPI uses a hyphen (setuptools…
richarddushime Mar 20, 2025
3c4e281
updating the generated pyproject.toml to use setuptools-scm
richarddushime Mar 20, 2025
b5c9d90
small typos
richarddushime Mar 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions tests/test_cookiecutter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,13 +272,13 @@ def test_pyproject_toml(package_path_config_dict):
"mypy",
"pre-commit",
"ruff",
"setuptools_scm",
"setuptools-scm",
]

assert project_toml["build-system"]["requires"] == [
"setuptools>=45",
"setuptools>=64",
"wheel",
"setuptools_scm[toml]>=6.2",
"setuptools-scm[toml]>=8",
Copy link
Member

@adamltyson adamltyson Mar 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason for enforcing this version?

Copy link
Contributor Author

@richarddushime richarddushime Mar 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This project supports Python3 and specificallly 3.11+ and based on the documentation on Pypi 6.2 has lower versions check programing languages Tab.

looking at the 8 Programming Language Tab exactly uses what this projects supports and This ensures good TOML configuration and fewer legacy issues.

Copy link
Contributor Author

@richarddushime richarddushime Mar 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there is something i am missing out , please let me know , I will update it, but this is based on what i am reading in the code so far.

]

assert (
Expand Down
6 changes: 3 additions & 3 deletions {{cookiecutter.package_name}}/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,14 +67,14 @@ dev = [
"mypy",
"pre-commit",
"ruff",
"setuptools_scm",
"setuptools-scm",
]

[build-system]
requires = [
"setuptools>=45",
"setuptools>=64",
"wheel",
"setuptools_scm[toml]>=6.2",
"setuptools-scm[toml]>=8",
]
build-backend = "setuptools.build_meta"

Expand Down