Skip to content

Upgrade @newfold/ui-component-library to version 2.0.0 #833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

desrosj
Copy link
Member

@desrosj desrosj commented Jul 29, 2025

Proposed changes

This resolves a peer dependency conflict for @wordpress/element described in #832.

Type of Change

There are some changes to built files that result from the build script. But I'm not sure the right way to test this. They are written to the build/3.0.3 directory, which is already released. I could also be following an incorrect Git flow.

Production

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update
  • Refactoring / housekeeping (changes to files not directly related to functionality)

Development

  • Tests
  • Dependency update
  • Environment update / refactoring
  • Documentation Update

Visual

Checklist

  • I have read the CONTRIBUTING doc
  • I have viewed my change in a web-browser
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

This resolves a peer dependency conflict for `@wordpress/element`.
@desrosj desrosj self-assigned this Jul 29, 2025
@Copilot Copilot AI review requested due to automatic review settings July 29, 2025 20:07
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR upgrades the @newfold/ui-component-library from version 1.3.0 to 2.0.0 to resolve a peer dependency conflict with @wordpress/element as described in issue #832.

  • Updated the major version of @newfold/ui-component-library from ^1.3.0 to ^2.0.0

@@ -37,7 +37,7 @@
"dependencies": {
"@heroicons/react": "^2.2.0",
"@newfold/js-utility-ui-analytics": "^1.4.0",
"@newfold/ui-component-library": "^1.3.0",
"@newfold/ui-component-library": "^2.0.0",
Copy link
Preview

Copilot AI Jul 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a major version upgrade which may introduce breaking changes. Consider reviewing the changelog of @newfold/ui-component-library v2.0.0 to identify any breaking changes that might affect the codebase and ensure all usages are updated accordingly.

Copilot uses AI. Check for mistakes.

@desrosj
Copy link
Member Author

desrosj commented Jul 29, 2025

It seems like @wordpress/element was last updated in 411cc20.

@desrosj desrosj requested a review from zlateska July 29, 2025 20:08
Copy link
Contributor

@desrosj desrosj requested review from wpalani and circlecube July 29, 2025 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant