Skip to content

refactor(agent): improve logging when adding named tracers #1061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 12, 2025
Merged

refactor(agent): improve logging when adding named tracers #1061

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions agent/php_user_instrument.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -570,13 +570,13 @@ nruserfn_t* nr_php_add_custom_tracer_named(const char* namestr,
return p; /* return the wraprec we are duplicating */
}
}
#else
wraprec = nr_php_user_instrument_wraprec_hashmap_add(namestr, namestrlen);
#endif
nrl_verbosedebug(
NRL_INSTRUMENT, "adding custom for '" NRP_FMT_UQ "%.5s" NRP_FMT_UQ "'",
NRP_PHP(wraprec->classname),
(0 == wraprec->classname) ? "" : "::", NRP_PHP(wraprec->funcname));
#else
wraprec = nr_php_user_instrument_wraprec_hashmap_add(namestr, namestrlen);
#endif

nr_php_wrap_user_function_internal(wraprec TSRMLS_CC);
nr_php_add_custom_tracer_common(wraprec);
Expand Down
1 change: 1 addition & 0 deletions agent/php_user_instrument_wraprec_hashmap.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -437,6 +437,7 @@ nruserfn_t* nr_php_user_instrument_wraprec_hashmap_add(const char* namestr, size

wraprec->supportability_metric = nr_txn_create_fn_supportability_metric(
wraprec->funcname, wraprec->classname);
nrl_verbosedebug(NRL_INSTRUMENT, "adding custom wrapper for '%s'", namestr);
} else {
nrl_verbosedebug(NRL_INSTRUMENT, "reusing custom wrapper for '%s'", namestr);
}
Expand Down