Skip to content

Conversation

lavarou
Copy link
Member

@lavarou lavarou commented May 12, 2025

Make log messages easier to understand when adding a named custom tracer by logging only a single message. Instead of logging one message when the wraprec is added, and two messages when wraprec is re-used, log a single message that indicates if the wraprec was added or re-used.

Make log messages easier to understand when adding a named custom tracer by
logging only a single message. Instead of logging one message when the wraprec
is added, and two messages when wraprec is re-used, log a single message that
indicates if the wraprec was added or re-used.
@lavarou lavarou added this to the next-release milestone May 12, 2025
@lavarou lavarou requested review from ZNeumann and zsistla May 12, 2025 18:10
@newrelic-php-agent-bot
Copy link

newrelic-php-agent-bot commented May 12, 2025

Test Suite Status Result
Multiverse 8/8 passing
SOAK 84/85 passing

@codecov-commenter
Copy link

codecov-commenter commented May 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.25%. Comparing base (1099f17) to head (8bfd618).

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1061      +/-   ##
==========================================
+ Coverage   77.08%   77.25%   +0.17%     
==========================================
  Files         198      199       +1     
  Lines       28126    28306     +180     
==========================================
+ Hits        21680    21869     +189     
+ Misses       6446     6437       -9     
Flag Coverage Δ
agent-for-php-7.2 77.47% <100.00%> (+<0.01%) ⬆️
agent-for-php-7.3 77.49% <100.00%> (?)
agent-for-php-7.4 77.36% <100.00%> (?)
agent-for-php-8.0 76.56% <100.00%> (?)
agent-for-php-8.1 76.88% <100.00%> (+<0.01%) ⬆️
agent-for-php-8.2 76.50% <100.00%> (+<0.01%) ⬆️
agent-for-php-8.3 76.50% <100.00%> (?)
agent-for-php-8.4 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lavarou lavarou merged commit 5b84fc8 into dev May 12, 2025
65 checks passed
@lavarou lavarou deleted the refactor/improve-logging-when-adding-wraprecs-alternative branch May 12, 2025 19:15
hahuja2 pushed a commit that referenced this pull request Jul 9, 2025
Make log messages easier to understand when adding a named custom tracer
by logging only a single message. Instead of logging one message when
the wraprec is added, and two messages when wraprec is re-used, log a
single message that indicates if the wraprec was added or re-used.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants