Skip to content

ci: add native arm64 GHA runner support #1066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
May 22, 2025
Merged

ci: add native arm64 GHA runner support #1066

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
14a2615
ci: add native arm64 runners for run-integration-tests
bduranleau-nr May 8, 2025
8c5c05d
ci: add arm64 native runners to test-pull-request workflow
bduranleau-nr May 19, 2025
d10758f
ci: remove arm emulation from make-integration-tests
bduranleau-nr May 19, 2025
e30d27f
ci: remove arm emulation from make-agent
bduranleau-nr May 19, 2025
316abc4
fix arm64 x codecov matrix
bduranleau-nr May 19, 2025
2defbb0
fix `needs` to match arch
bduranleau-nr May 19, 2025
3393571
fix: use env variable to determine mysqldb platform
bduranleau-nr May 19, 2025
06084ea
testing: try lts mysql for arm64 image availability
bduranleau-nr May 19, 2025
9f96a36
revert mysql service changes
bduranleau-nr May 19, 2025
a686d66
testing: amd64 emulation for mysql container
bduranleau-nr May 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions .github/workflows/make-agent.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,12 +40,6 @@ jobs:
path: php-agent
repository: ${{ inputs.origin }}/newrelic-php-agent
ref: ${{ inputs.ref }}
- name: Enable arm64 emulation
if: ${{ inputs.arch == 'arm64' }}
uses: docker/setup-qemu-action@v3
with:
image: tonistiigi/binfmt:${{vars.BINFMT_IMAGE_VERSION}}
platforms: arm64
- name: Login to Docker Hub
uses: docker/login-action@v3
with:
Expand Down
6 changes: 0 additions & 6 deletions .github/workflows/make-integration-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,12 +56,6 @@ jobs:
run: |
chmod 755 php-agent/bin/integration_runner
chmod 755 php-agent/agent/modules/newrelic.so
- name: Enable arm64 emulation
if: ${{ inputs.arch == 'arm64' }}
uses: docker/setup-qemu-action@v3
with:
image: tonistiigi/binfmt:${{vars.BINFMT_IMAGE_VERSION}}
platforms: arm64
- name: Login to Docker Hub
uses: docker/login-action@v3
with:
Expand Down
13 changes: 5 additions & 8 deletions .github/workflows/run-integration-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,14 +21,11 @@ on:
runner-type:
description: 'Type of a runner to use for integration tests on arm64'
required: true
default: 'ubuntu-20.04-4core'
default: 'ubuntu-24.04-arm'
type: choice
options:
- ubuntu-20.04-4core
- ubuntu-20.04-8core
- ubuntu-20.04-16core
- ubuntu-22.04-4core
- ubuntu-latest
- ubuntu-22.04-arm
- ubuntu-24.04-arm

jobs:
build-test-runner-amd64:
Expand All @@ -55,7 +52,7 @@ jobs:
artifact-name: integration_runner
artifact-pattern: bin/integration_runner
arch: arm64
runs-on: ubuntu-latest
runs-on: ${{inputs.runner-type}}
secrets: inherit

build-agent-amd64:
Expand All @@ -72,7 +69,7 @@ jobs:
origin: ${{ inputs.origin }}
ref: ${{ inputs.ref }}
arch: arm64
runs-on: ubuntu-latest
runs-on: ${{inputs.runner-type}}
secrets: inherit

test-amd64:
Expand Down
Loading