Skip to content

Conversation

lavarou
Copy link
Member

@lavarou lavarou commented Jun 24, 2025

No description provided.

ZNeumann and others added 7 commits May 20, 2025 14:01
`nr_execute_handle_autoload` wasn't accounting for the possibility of
txn being null which would lead to unpredictable behavior when accessing
it
[here](https://github.com/newrelic/newrelic-php-agent/blob/dev/agent/php_execute.c#L894),
and we would cause corruption when we [set this
value](https://github.com/newrelic/newrelic-php-agent/blob/dev/agent/php_execute.c#L907).

txn can be null in cases where nr_php_txn_end has been called.
such as:
https://github.com/newrelic/newrelic-php-agent/blob/dev/agent/fw_laravel_queue.c#L355-L356
Changes the default configuration value for composer-based package
detection to `true`.

An additional configuration value,
`newrelic.vulnerability_management.composer_api.per_process_detection`,
has also been added to control the frequency at which composer sampling
occurs. By default, this setting will be enabled, only sampling Composer
API data once per php-fpm process. This improves baseline performance to
make the enablement of Composer API package detection a negligible
overhead impact.

---------

Co-authored-by: Michael Fulbright <[email protected]>
Force non-zero duration of helper user function. When tests execute fast
enough, the helper function's segment start time and end time are equal
and this causes the segment to be dropped. To address this test
instability, non-zero duration is forced on test helper user functions.
This is a follow up to #781.
This PR:
1) adds the option to run valgrind on integration tests in GHA
2) adds the ability to run valgrind on CGI tests
3) no longer runs valgrind on SKIPIFs
4) changes the valgrind lock mechanism to allow subprocesses (i.e. curl)
to not be locked out
@lavarou lavarou added this to the 11.10.0 milestone Jun 24, 2025
@lavarou lavarou requested a review from mfulb June 24, 2025 19:05
@newrelic-php-agent-bot
Copy link

newrelic-php-agent-bot commented Jun 24, 2025

Test Suite Status Result
Multiverse 8/8 passing
SOAK 82/85 passing

@codecov-commenter
Copy link

codecov-commenter commented Jun 24, 2025

Codecov Report

Attention: Patch coverage is 73.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 77.27%. Comparing base (143cf0c) to head (4706504).

Files with missing lines Patch % Lines
agent/php_execute.c 60.00% 2 Missing ⚠️
agent/php_nrini.c 71.42% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1091   +/-   ##
=======================================
  Coverage   77.27%   77.27%           
=======================================
  Files         199      199           
  Lines       28327    28342   +15     
=======================================
+ Hits        21890    21902   +12     
- Misses       6437     6440    +3     
Flag Coverage Δ
agent-for-php-7.2 77.47% <73.33%> (+<0.01%) ⬆️
agent-for-php-7.3 77.49% <73.33%> (+<0.01%) ⬆️
agent-for-php-7.4 77.36% <73.33%> (-0.01%) ⬇️
agent-for-php-8.0 76.56% <73.33%> (-0.01%) ⬇️
agent-for-php-8.1 76.88% <73.33%> (-0.01%) ⬇️
agent-for-php-8.2 76.50% <73.33%> (-0.01%) ⬇️
agent-for-php-8.3 76.50% <73.33%> (-0.01%) ⬇️
agent-for-php-8.4 76.52% <73.33%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lavarou lavarou merged commit 765888d into main Jun 24, 2025
128 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants