build(daemon): allow daemon-golang-verify to pass when requested #1135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an option to override default behavior of daemon-golang-verify target, which is to fail the build if golang version used to build the daemon does not match the toolchain version from go.mod. Overriding this behavior is beneficial when trying to test building the daemon with more recent version of golang.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #1135 +/- ##
=======================================
Coverage 78.40% 78.40%
=======================================
Files 193 193
Lines 28067 28067
=======================================
Hits 22007 22007
Misses 6060 6060
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
hahuja2
approved these changes
Nov 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an option to override default behavior of daemon-golang-verify target, which is to fail the build if golang version used to build the daemon does not match the toolchain version from go.mod. Overriding this behavior is beneficial when trying to test building the daemon with more recent version of golang.