Skip to content

build(daemon): allow daemon-golang-verify to pass when requested #1135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

build(daemon): allow daemon-golang-verify to pass when requested #1135

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,12 +167,19 @@ agent-valgrind: agent/Makefile
# Configure the target directory for go install
export GOBIN=$(CURDIR)/bin

# By default daemon golang verification will cause the build to fail. This
# behavior can be overriden by setting GOLANG_VERIFICATION_FAILURE_SEVERITY
# to a value different than ERROR. Overriding this value is helpful when
# trying to build the agent with more recent version of go than the one
# defined by toolchain go.mod.
GOLANG_VERIFICATION_FAILURE_SEVERITY ?= ERROR
.PHONY: daemon-golang-verify
daemon-golang-verify:
@golang_in_binary=$$(go version -m bin/daemon | awk '/^bin\/daemon/ {print $$2;}') \
&& golang_from_toolchain=$$(awk '/^toolchain/ {print $$2;}' daemon/go.mod) \
&& [ "$$golang_in_binary" = "$$golang_from_toolchain" ] && echo "daemon built using: $$golang_from_toolchain" \
|| { echo "ERROR: daemon built using go: $$golang_in_binary, required: $$golang_from_toolchain"; exit 1; }
|| { echo "$(GOLANG_VERIFICATION_FAILURE_SEVERITY): daemon built using go: $$golang_in_binary, required: $$golang_from_toolchain"; \
[ "$(GOLANG_VERIFICATION_FAILURE_SEVERITY)" != "ERROR" ] || exit 1; }

.PHONY: daemon
daemon:
Expand Down
Loading