Skip to content

oracledb Package Instrumentation#1423

Merged
TimPansino merged 10 commits intomainfrom
feature-oracledb
Jul 21, 2025
Merged

oracledb Package Instrumentation#1423
TimPansino merged 10 commits intomainfrom
feature-oracledb

Conversation

@TimPansino
Copy link
Contributor

@TimPansino TimPansino commented Jul 7, 2025

Overview

  • Add instrumentation for oracledb.
    • Instruments both sync and async connections through DBAPI2 when using connect() or connect_async().
    • Attempts to parse instance info from multiple sources, falling back to "unknown".

Related

Closes #1420

@TimPansino TimPansino requested a review from a team as a code owner July 7, 2025 19:08
@github-actions
Copy link

github-actions bot commented Jul 7, 2025

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ ACTION actionlint 6 0 0 0.7s
⚠️ MARKDOWN markdownlint 7 0 1 0 1.08s
✅ MARKDOWN markdown-link-check 7 0 0 33.52s
✅ PYTHON ruff 921 0 0 0 0.9s
✅ PYTHON ruff-format 921 0 0 0 0.26s
✅ YAML prettier 13 0 0 0 1.13s
✅ YAML v8r 13 0 0 5.79s
✅ YAML yamllint 13 0 0 0.62s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

@codecov-commenter
Copy link

codecov-commenter commented Jul 7, 2025

Codecov Report

Attention: Patch coverage is 87.01299% with 10 lines in your changes missing coverage. Please review.

Project coverage is 81.36%. Comparing base (69692b3) to head (8c40bbf).

Files with missing lines Patch % Lines
newrelic/hooks/database_oracledb.py 86.84% 8 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1423      +/-   ##
==========================================
+ Coverage   81.33%   81.36%   +0.03%     
==========================================
  Files         207      208       +1     
  Lines       23466    23543      +77     
  Branches     3710     3715       +5     
==========================================
+ Hits        19086    19156      +70     
- Misses       3121     3129       +8     
+ Partials     1259     1258       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mergify mergify bot added tests-failing Tests failing in CI. and removed tests-failing Tests failing in CI. labels Jul 7, 2025
hmstepanek
hmstepanek previously approved these changes Jul 21, 2025
Copy link
Contributor

@hmstepanek hmstepanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just had one question about whether we want to support/test on any older versions than latest.

@TimPansino TimPansino merged commit d4e359a into main Jul 21, 2025
60 checks passed
@TimPansino TimPansino deleted the feature-oracledb branch July 21, 2025 21:33
@lrafeei lrafeei added this to the v10.15.0 milestone Jul 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Instrument python-oracledb as cx_Oracle is obsolete

4 participants